Reland of "Decouple GpuCompositorFrameSink from DisplayCompositor"

Reland of "Decouple GpuCompositorFrameSink from DisplayCompositor"

In order to reuse GpuCompositorFrameSink in other parts of Chrome
(e.g. OffscreenCanvas), this CL decouples
GpuCompositorFrameSinkSupport from DisplayCompositor.

This CL also moves GpuCompositorFrameSInk out of
services/ui/surfaces for now as well because we would like to use
this code in Chrome and this is currently an incomplete internal
implementation detail of Mus. Once code is unified between Chrome
and Mus, components/display_compositor can probably move to
services/ui/gpu/display_compositor.

BUG=683735
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2654693003
Cr-Commit-Position: refs/heads/master@{#446223}
(cherry picked from commit 81183e45cf14c416dfce69b990a0c71a4e1c3399)

[xing.xu, 2017-01-26 06:28:29]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 06:28:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xing.xu, 2017-01-26 07:15:33]

Description was changed from

==========
Reland of "Decouple GpuCompositorFrameSink from DisplayCompositor"

In order to reuse GpuCompositorFrameSink in other parts of Chrome
(e.g. OffscreenCanvas), this CL decouples
GpuCompositorFrameSinkSupport from DisplayCompositor.

This CL also moves GpuCompositorFrameSInk out of
services/ui/surfaces for now as well because we would like to use
this code in Chrome and this is currently an incomplete internal
implementation detail of Mus. Once code is unified between Chrome
and Mus, components/display_compositor can probably move to
services/ui/gpu/display_compositor.

BUG=683735
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2654693003
Cr-Commit-Position: refs/heads/master@{#446223}
(cherry picked from commit 81183e45cf14c416dfce69b990a0c71a4e1c3399)
==========

to

==========
Reland of "Decouple GpuCompositorFrameSink from DisplayCompositor"

In order to reuse GpuCompositorFrameSink in other parts of Chrome
(e.g. OffscreenCanvas), this CL decouples
GpuCompositorFrameSinkSupport from DisplayCompositor.

This CL also moves GpuCompositorFrameSInk out of
services/ui/surfaces for now as well because we would like to use
this code in Chrome and this is currently an incomplete internal
implementation detail of Mus. Once code is unified between Chrome
and Mus, components/display_compositor can probably move to
services/ui/gpu/display_compositor.

BUG=683735
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2654693003
Cr-Commit-Position: refs/heads/master@{#446223}
(cherry picked from commit 81183e45cf14c416dfce69b990a0c71a4e1c3399)
==========

[xing.xu, 2017-01-26 07:15:33]

xing.xu@intel.com changed reviewers:
+ danakj@chromium.org, fsamuel@chromium.org, jam@chromium.org,
kylechar@chromium.org

[xing.xu, 2017-01-26 07:18:55]

PTAL.
patch https://codereview.chromium.org/2654693003/ was mistakenly reverted here:
https://codereview.chromium.org/2651213004/. So reland it here.

I tried git cl reland, but it failed and my local code seems in mess. Is there
any guideline or document about how to git cl reland? 
Then I tried git cherry-pick, and reland it here.

[xing.xu, 2017-01-26 07:20:07]

xing.xu@intel.com changed reviewers:
+ dbeam@chromium.org, kjellander@chromium.org

[commit-bot: I haz the power, 2017-01-26 07:32:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 07:32:00]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2017-01-26 12:43:44]

lgtm

[kjellander_chromium, 2017-01-26 12:55:41]

lgtm

[xing.xu, 2017-01-26 14:42:14]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2017-01-26 14:42:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 14:49:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 14:49:11]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xing.xu, 2017-01-26 14:49:39]

xing.xu@intel.com changed reviewers:
+ ben@chromium.org

[danakj, 2017-01-26 16:12:42]

Just reopen https://codereview.chromium.org/2654693003/ and CQ it again, then
you don't need to ask for new reviews.

[xing.xu, 2017-01-26 18:14:28]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2017-01-26 18:14:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 18:23:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 18:23:17]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xing.xu, 2017-01-26 18:34:00]

On 2017/01/26 16:12:42, danakj (slow) wrote:
> Just reopen https://codereview.chromium.org/2654693003/ and CQ it again, then
> you don't need to ask for new reviews.


Thanks, @danakj,
In this cl, you mentioned “Just reopen
https://codereview.chromium.org/2654693003/ and CQ it again”.
But I still cannot successfully  commit in both CLs.

When click Commit in Issue 2651283004: Reland of "Decouple
GpuCompositorFrameSink from DisplayCompositor",error reports review required,
https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presu...
As to Issue 2654693003: Decouple GpuCompositorFrameSink from DisplayCompositor,
its Commit button is disabled.

So what further action should I take? BTW, is there any guideline about how to
reland a CL?

[danakj, 2017-01-26 18:35:12]

On Thu, Jan 26, 2017 at 1:34 PM, <xing.xu@intel.com> wrote:

> On 2017/01/26 16:12:42, danakj (slow) wrote:
> > Just reopen https://codereview.chromium.org/2654693003/ and CQ it
> again, then
> > you don't need to ask for new reviews.
>
>
> Thanks, @danakj,
> In this cl, you mentioned “Just reopen
> https://codereview.chromium.org/2654693003/ and CQ it again”.
> But I still cannot successfully commit in both CLs.
>

You have to open it first. Click "edit issue" to do so.


>
> When click Commit in Issue 2651283004: Reland of "Decouple
> GpuCompositorFrameSink from DisplayCompositor",error reports review
> required,
> https://build.chromium.org/p/tryserver.chromium.linux/
> builders/chromium_presubmit/builds/351166
> As to Issue 2654693003: Decouple GpuCompositorFrameSink from
> DisplayCompositor,
> its Commit button is disabled.
>
> So what further action should I take? BTW, is there any guideline about
> how to
> reland a CL?
>
> https://codereview.chromium.org/2651283004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jam, 2017-01-26 19:03:40]

lgtm for components/display_compositor/DEPS

in the future when relanding, please first upload the reverted code, then in
another patchset upload the fixes. that way it's easy for reviewers to see what
changed

[Dan Beam, 2017-01-26 19:59:47]

On 2017/01/26 19:03:40, jam wrote:
> lgtm for components/display_compositor/DEPS
> 
> in the future when relanding, please first upload the reverted code, then in
> another patchset upload the fixes. that way it's easy for reviewers to see
what
> changed

there were no fixes, I mistakenly reverted this CL because it looked related to
a compile failure (that ended up being
https://bugs.chromium.org/p/chromium/issues/detail?id=685440 instead)

[xing.xu, 2017-01-26 23:53:47]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2017-01-26 23:54:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xing.xu, 2017-01-26 23:57:05]

The CQ bit was unchecked by xing.xu@intel.com

[kylechar, 2017-02-01 03:05:51]

kylechar@chromium.org changed reviewers:
- kylechar@chromium.org

[xing.xu, 2017-02-01 10:39:19]

Now that https://codereview.chromium.org/2654693003/ was relanded, so no more
review for this. Will close this.