Revert of Fix shouldPaint issue when a composited floating iframe becomes non-self-painting

Revert of Fix shouldPaint issue when a composited floating iframe becomes non-self-painting (patchset #4 id:60001 of https://codereview.chromium.org/2654843004/ )

Reason for revert:
Fails on https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/49858
Snippet:
20:56:41.220 1868 worker/4 compositing/iframes/floating-self-painting-frame-complex.html output stderr lines:
20:56:41.220 1868   [5864:3688:0125/205640.620:601633:ERROR:graphicslayer.cpp(1294)] "LayoutView #document" Uninvalidated old/new pixels mismatch at 411,8 old:ffc4c4c4 new:fec4c4c4
20:56:41.294 1868 "E:\b\c\b\win_layout\src\out\Release\image_diff.exe --diff c:\users\chrome~2\appdata\local\temp\tmpous4g4\actual.png c:\users\chrome~2\appdata\local\temp\tmpous4g4\expected.png c:\users\chrome~2\appdata\local\temp\tmpous4g4\diff.png" took 0.07s
20:56:41.389 1868 "E:\b\c\b\win_layout\src\out\Release\image_diff.exe --diff c:\users\chrome~2\appdata\local\temp\tmpaddjzm\actual.png c:\users\chrome~2\appdata\local\temp\tmpaddjzm\expected.png c:\users\chrome~2\appdata\local\temp\tmpaddjzm\diff.png" took 0.09s
20:56:41.393 3184 [6230/47861] compositing/iframes/floating-self-painting-frame-complex.html failed unexpectedly (reference mismatch)
20:56:41.392 1868 worker/4 compositing/iframes/floating-self-painting-frame-complex.html failed:
20:56:41.392 1868 worker/4  reference mismatch

Original issue's description:
> Fix shouldPaint issue when a composited floating iframe becomes non-self-painting
> 
> Previously we forced selfPainting flags (but let selfPainting() function
> return false) on all blocks into which a composited (for certain reason)
> floating iframe overhangs or intrudes. When the iframe became non-self-
> painting, all these blocks will paint the float. This caused multiple
> issues, such as duplicated painting, display items with duplicated ids,
> subsequence caching disorders, etc.
> 
> This CL contains two parts:
> 1. Revert crrev.com/413649 which caused the problems;
> 2. Set PaintLayer::selfPaintingStatusChanged() when self-painting status
>    changes, and check it and clear it during compositing update.
>    If the status changed for a floating layer, update ancestor
>    shouldPaint flags to reflect the new status.
> 
> BUG=680423
> TEST=compositing/iframes/floating-self-painting-frame.html
> TEST=compositing/iframes/floating-self-painting-frame-expected.html
> TEST=fast/block/float/float-change-composited-scrolling.html
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> R=chrishtr@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2654843004 .
> Cr-Commit-Position: refs/heads/master@{#446226}
> Committed: https://chromium.googlesource.com/chromium/src/+/574d079a3f53ebfae2d34cc304fe8613cbcdf593

TBR=chrishtr@chromium.org,wangxianzhu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=680423
Review-Url: https://codereview.chromium.org/2651253003
Cr-Commit-Position: refs/heads/master@{#446271}
Committed: https://chromium.googlesource.com/chromium/src/+/59473b9e2c27131e748807e5390d33f20fcacc97

[kjellander_chromium, 2017-01-26 07:52:21]

The CQ bit was checked by kjellander@chromium.org

[kjellander_chromium, 2017-01-26 07:52:22]

Created Revert of Fix shouldPaint issue when a composited floating iframe
becomes non-self-painting

[commit-bot: I haz the power, 2017-01-26 07:52:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 07:53:24]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485417141962550, "parent_rev":
"16de2c25e724f07d46b68f5758e49fae6f136073", "commit_rev":
"59473b9e2c27131e748807e5390d33f20fcacc97"}

[commit-bot: I haz the power, 2017-01-26 07:53:59]

Description was changed from

==========
Revert of Fix shouldPaint issue when a composited floating iframe becomes
non-self-painting (patchset #4 id:60001 of
https://codereview.chromium.org/2654843004/ )

Reason for revert:
Fails on
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/49858
Snippet:
20:56:41.220 1868 worker/4
compositing/iframes/floating-self-painting-frame-complex.html output stderr
lines:
20:56:41.220 1868  
[5864:3688:0125/205640.620:601633:ERROR:graphicslayer.cpp(1294)] "LayoutView
#document" Uninvalidated old/new pixels mismatch at 411,8 old:ffc4c4c4
new:fec4c4c4
20:56:41.294 1868 "E:\b\c\b\win_layout\src\out\Release\image_diff.exe --diff
c:\users\chrome~2\appdata\local\temp\tmpous4g4\actual.png
c:\users\chrome~2\appdata\local\temp\tmpous4g4\expected.png
c:\users\chrome~2\appdata\local\temp\tmpous4g4\diff.png" took 0.07s
20:56:41.389 1868 "E:\b\c\b\win_layout\src\out\Release\image_diff.exe --diff
c:\users\chrome~2\appdata\local\temp\tmpaddjzm\actual.png
c:\users\chrome~2\appdata\local\temp\tmpaddjzm\expected.png
c:\users\chrome~2\appdata\local\temp\tmpaddjzm\diff.png" took 0.09s
20:56:41.393 3184 [6230/47861]
compositing/iframes/floating-self-painting-frame-complex.html failed
unexpectedly (reference mismatch)
20:56:41.392 1868 worker/4
compositing/iframes/floating-self-painting-frame-complex.html failed:
20:56:41.392 1868 worker/4  reference mismatch

Original issue's description:
> Fix shouldPaint issue when a composited floating iframe becomes
non-self-painting
> 
> Previously we forced selfPainting flags (but let selfPainting() function
> return false) on all blocks into which a composited (for certain reason)
> floating iframe overhangs or intrudes. When the iframe became non-self-
> painting, all these blocks will paint the float. This caused multiple
> issues, such as duplicated painting, display items with duplicated ids,
> subsequence caching disorders, etc.
> 
> This CL contains two parts:
> 1. Revert crrev.com/413649 which caused the problems;
> 2. Set PaintLayer::selfPaintingStatusChanged() when self-painting status
>    changes, and check it and clear it during compositing update.
>    If the status changed for a floating layer, update ancestor
>    shouldPaint flags to reflect the new status.
> 
> BUG=680423
> TEST=compositing/iframes/floating-self-painting-frame.html
> TEST=compositing/iframes/floating-self-painting-frame-expected.html
> TEST=fast/block/float/float-change-composited-scrolling.html
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> R=chrishtr@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2654843004 .
> Cr-Commit-Position: refs/heads/master@{#446226}
> Committed:
https://chromium.googlesource.com/chromium/src/+/574d079a3f53ebfae2d34cc304fe...

TBR=chrishtr@chromium.org,wangxianzhu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=680423
==========

to

==========
Revert of Fix shouldPaint issue when a composited floating iframe becomes
non-self-painting (patchset #4 id:60001 of
https://codereview.chromium.org/2654843004/ )

Reason for revert:
Fails on
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/49858
Snippet:
20:56:41.220 1868 worker/4
compositing/iframes/floating-self-painting-frame-complex.html output stderr
lines:
20:56:41.220 1868  
[5864:3688:0125/205640.620:601633:ERROR:graphicslayer.cpp(1294)] "LayoutView
#document" Uninvalidated old/new pixels mismatch at 411,8 old:ffc4c4c4
new:fec4c4c4
20:56:41.294 1868 "E:\b\c\b\win_layout\src\out\Release\image_diff.exe --diff
c:\users\chrome~2\appdata\local\temp\tmpous4g4\actual.png
c:\users\chrome~2\appdata\local\temp\tmpous4g4\expected.png
c:\users\chrome~2\appdata\local\temp\tmpous4g4\diff.png" took 0.07s
20:56:41.389 1868 "E:\b\c\b\win_layout\src\out\Release\image_diff.exe --diff
c:\users\chrome~2\appdata\local\temp\tmpaddjzm\actual.png
c:\users\chrome~2\appdata\local\temp\tmpaddjzm\expected.png
c:\users\chrome~2\appdata\local\temp\tmpaddjzm\diff.png" took 0.09s
20:56:41.393 3184 [6230/47861]
compositing/iframes/floating-self-painting-frame-complex.html failed
unexpectedly (reference mismatch)
20:56:41.392 1868 worker/4
compositing/iframes/floating-self-painting-frame-complex.html failed:
20:56:41.392 1868 worker/4  reference mismatch

Original issue's description:
> Fix shouldPaint issue when a composited floating iframe becomes
non-self-painting
> 
> Previously we forced selfPainting flags (but let selfPainting() function
> return false) on all blocks into which a composited (for certain reason)
> floating iframe overhangs or intrudes. When the iframe became non-self-
> painting, all these blocks will paint the float. This caused multiple
> issues, such as duplicated painting, display items with duplicated ids,
> subsequence caching disorders, etc.
> 
> This CL contains two parts:
> 1. Revert crrev.com/413649 which caused the problems;
> 2. Set PaintLayer::selfPaintingStatusChanged() when self-painting status
>    changes, and check it and clear it during compositing update.
>    If the status changed for a floating layer, update ancestor
>    shouldPaint flags to reflect the new status.
> 
> BUG=680423
> TEST=compositing/iframes/floating-self-painting-frame.html
> TEST=compositing/iframes/floating-self-painting-frame-expected.html
> TEST=fast/block/float/float-change-composited-scrolling.html
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> R=chrishtr@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2654843004 .
> Cr-Commit-Position: refs/heads/master@{#446226}
> Committed:
https://chromium.googlesource.com/chromium/src/+/574d079a3f53ebfae2d34cc304fe...

TBR=chrishtr@chromium.org,wangxianzhu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=680423

Review-Url: https://codereview.chromium.org/2651253003
Cr-Commit-Position: refs/heads/master@{#446271}
Committed:
https://chromium.googlesource.com/chromium/src/+/59473b9e2c27131e748807e5390d...
==========

[commit-bot: I haz the power, 2017-01-26 07:54:00]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/59473b9e2c27131e748807e5390d...

[Xianzhu, 2017-01-26 17:05:59]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2656113002/ by wangxianzhu@chromium.org.

The reason for reverting is: The layout test failure was because of difference
of a pixel at the top-right
corner of the iframe: 0xffc4c4c4 vs 0xfec4c4c4. This is an acceptable
difference, but to make the test pass, remove the border from the iframe..