third_party/WebKit/Source/core/paint/BlockFlowPainter.cpp - Issue 2651253003: Revert of Fix shouldPaint issue when a composited floating iframe becomes non-self-painting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/BlockFlowPainter.cpp

Issue 2651253003: Revert of Fix shouldPaint issue when a composited floating iframe becomes non-self-painting (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/BlockFlowPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/BlockFlowPainter.cpp b/third_party/WebKit/Source/core/paint/BlockFlowPainter.cpp

index 0ac6dd659b642bb3bd07362ed8ae7be405ee7e22..816eaf5cf43ecdd038a9061c3c231b07cc450d9c 100644

--- a/third_party/WebKit/Source/core/paint/BlockFlowPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/BlockFlowPainter.cpp

@@ -53,10 +53,6 @@

continue;

const LayoutBox* floatingLayoutObject = floatingObject->layoutObject();

- // TODO(wangxianzhu): Should this be a DCHECK?

- if (floatingLayoutObject->hasSelfPaintingLayer())

- continue;

// FIXME: LayoutPoint version of xPositionForFloatIncludingMargin would make

// this much cleaner.

LayoutPoint childPoint = m_layoutBlockFlow.flipFloatForWritingModeForChild(