Reland of Add assembly for x86 to OpenH264 encoder

Reland of Add assembly for x86 to OpenH264 encoder (patchset #1 id:1 of https://codereview.chromium.org/2651643004/ )

Reason for revert:
Disabling assembly for MSAN build.

Original issue's description:
> Revert of Add assembly for x86 to OpenH264 encoder (patchset #2 id:40001 of https://codereview.chromium.org/2645293002/ )
> 
> Reason for revert:
> Causes linux_msan to flake about uninitialized value, this warning needs to be ignored before re-landing. Example: https://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/16972
> 
> The address of the uninitialized value is used when calling a function through a function pointer. The function writes to this value so it's safe, but linux_msan doesn't know that.
> 
> Original issue's description:
> > Reland of Add assembly for x86 to OpenH264 encoder (patchset #1 id:1 of https://codereview.chromium.org/2651543002/ )
> >
> > Reason for revert:
> > Reland
> >
> > Original issue's description:
> > > Revert of Add assembly for x86 to OpenH264 encoder (patchset #5 id:80001 of https://codereview.chromium.org/2585733002/ )
> > >
> > > Reason for revert:
> > > This broke Chrome OS builders:
> > >
> > > https://uberchromegw.corp.google.com/i/chromeos/builders/veyron_minnie-chrome-pfq/builds/669/steps/BuildPackages/logs/stdio
> > >
> > >
> > > Original issue's description:
> > > > Add assembly for x86 to OpenH264 encoder
> > > >
> > > > On Linux on a build workstation, these changes seem to give around 2.5x faster encoding (frame encode time in test goes from ~25 to ~9 ms)
> > > >
> > > > We do expect alerts from our performance bots when this lands.
> > > >
> > > > Credit: These build changes were written by brian@highfive.com aka bbaldino@gmail.com.
> > > >
> > > > BUG=600399
> > > >
> > > > Review-Url: https://codereview.chromium.org/2585733002
> > > > Cr-Commit-Position: refs/heads/master@{#445033}
> > > > Committed: https://chromium.googlesource.com/chromium/src/+/6d1501f500099ff3e25f92593e9efcb27d352252
> > >
> > > TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kthelgason@webrtc.org,hta@chromium.org
> > > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > > BUG=600399
> > >
> > > Review-Url: https://codereview.chromium.org/2651543002
> > > Cr-Commit-Position: refs/heads/master@{#445311}
> > > Committed: https://chromium.googlesource.com/chromium/src/+/3f4ee1b009741853987773717ebc2f22c5f0c60b
> >
> >
> > BUG=600399
> >
> > Review-Url: https://codereview.chromium.org/2645293002
> > Cr-Commit-Position: refs/heads/master@{#445358}
> > Committed: https://chromium.googlesource.com/chromium/src/+/2c39ea391c4df544e2f6162ae595083ce2d04e99
> 
> TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kjellander@chromium.org,haraken@chromium.org,hta@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=600399
> 
> Review-Url: https://codereview.chromium.org/2651643004
> Cr-Commit-Position: refs/heads/master@{#445680}
> Committed: https://chromium.googlesource.com/chromium/src/+/95cc5f514856c42df9287ca5f68e3b632e6b0312

TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kjellander@chromium.org,haraken@chromium.org,hbos@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=600399
Review-Url: https://codereview.chromium.org/2651183003
Cr-Commit-Position: refs/heads/master@{#446649}
Committed: https://chromium.googlesource.com/chromium/src/+/2529431f34dfdfef0d698b5ab35a5c9cb9ff566a

[hta - Chromium, 2017-01-25 13:52:47]

Created Reland of Add assembly for x86 to OpenH264 encoder

[hta - Chromium, 2017-01-26 08:30:14]

The CQ bit was checked by hta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 08:30:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hta - Chromium, 2017-01-26 08:31:00]

Description was changed from

==========
Reland of Add assembly for x86 to OpenH264 encoder (patchset #1 id:1 of
https://codereview.chromium.org/2651643004/ )

Reason for revert:
Disabling assembly for MSAN build.

[note - do NOT review at this time. Not changed yet.]

Original issue's description:
> Revert of Add assembly for x86 to OpenH264 encoder (patchset #2 id:40001 of
https://codereview.chromium.org/2645293002/ )
> 
> Reason for revert:
> Causes linux_msan to flake about uninitialized value, this warning needs to be
ignored before re-landing. Example:
https://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/16972
> 
> The address of the uninitialized value is used when calling a function through
a function pointer. The function writes to this value so it's safe, but
linux_msan doesn't know that.
> 
> Original issue's description:
> > Reland of Add assembly for x86 to OpenH264 encoder (patchset #1 id:1 of
https://codereview.chromium.org/2651543002/ )
> >
> > Reason for revert:
> > Reland
> >
> > Original issue's description:
> > > Revert of Add assembly for x86 to OpenH264 encoder (patchset #5 id:80001
of https://codereview.chromium.org/2585733002/ )
> > >
> > > Reason for revert:
> > > This broke Chrome OS builders:
> > >
> > >
https://uberchromegw.corp.google.com/i/chromeos/builders/veyron_minnie-chrome...
> > >
> > >
> > > Original issue's description:
> > > > Add assembly for x86 to OpenH264 encoder
> > > >
> > > > On Linux on a build workstation, these changes seem to give around 2.5x
faster encoding (frame encode time in test goes from ~25 to ~9 ms)
> > > >
> > > > We do expect alerts from our performance bots when this lands.
> > > >
> > > > Credit: These build changes were written by brian@highfive.com aka
bbaldino@gmail.com.
> > > >
> > > > BUG=600399
> > > >
> > > > Review-Url: https://codereview.chromium.org/2585733002
> > > > Cr-Commit-Position: refs/heads/master@{#445033}
> > > > Committed:
https://chromium.googlesource.com/chromium/src/+/6d1501f500099ff3e25f92593e9e...
> > >
> > >
TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kthelgason@webrtc.org,ht...
> > > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > > BUG=600399
> > >
> > > Review-Url: https://codereview.chromium.org/2651543002
> > > Cr-Commit-Position: refs/heads/master@{#445311}
> > > Committed:
https://chromium.googlesource.com/chromium/src/+/3f4ee1b009741853987773717ebc...
> >
> >
> > BUG=600399
> >
> > Review-Url: https://codereview.chromium.org/2645293002
> > Cr-Commit-Position: refs/heads/master@{#445358}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/2c39ea391c4df544e2f6162ae595...
> 
>
TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kjellander@chromium.org,...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=600399
> 
> Review-Url: https://codereview.chromium.org/2651643004
> Cr-Commit-Position: refs/heads/master@{#445680}
> Committed:
https://chromium.googlesource.com/chromium/src/+/95cc5f514856c42df9287ca5f68e...

TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kjellander@chromium.org,...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=600399
==========

to

==========
Reland of Add assembly for x86 to OpenH264 encoder (patchset #1 id:1 of
https://codereview.chromium.org/2651643004/ )

Reason for revert:
Disabling assembly for MSAN build.

Original issue's description:
> Revert of Add assembly for x86 to OpenH264 encoder (patchset #2 id:40001 of
https://codereview.chromium.org/2645293002/ )
> 
> Reason for revert:
> Causes linux_msan to flake about uninitialized value, this warning needs to be
ignored before re-landing. Example:
https://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/16972
> 
> The address of the uninitialized value is used when calling a function through
a function pointer. The function writes to this value so it's safe, but
linux_msan doesn't know that.
> 
> Original issue's description:
> > Reland of Add assembly for x86 to OpenH264 encoder (patchset #1 id:1 of
https://codereview.chromium.org/2651543002/ )
> >
> > Reason for revert:
> > Reland
> >
> > Original issue's description:
> > > Revert of Add assembly for x86 to OpenH264 encoder (patchset #5 id:80001
of https://codereview.chromium.org/2585733002/ )
> > >
> > > Reason for revert:
> > > This broke Chrome OS builders:
> > >
> > >
https://uberchromegw.corp.google.com/i/chromeos/builders/veyron_minnie-chrome...
> > >
> > >
> > > Original issue's description:
> > > > Add assembly for x86 to OpenH264 encoder
> > > >
> > > > On Linux on a build workstation, these changes seem to give around 2.5x
faster encoding (frame encode time in test goes from ~25 to ~9 ms)
> > > >
> > > > We do expect alerts from our performance bots when this lands.
> > > >
> > > > Credit: These build changes were written by brian@highfive.com aka
bbaldino@gmail.com.
> > > >
> > > > BUG=600399
> > > >
> > > > Review-Url: https://codereview.chromium.org/2585733002
> > > > Cr-Commit-Position: refs/heads/master@{#445033}
> > > > Committed:
https://chromium.googlesource.com/chromium/src/+/6d1501f500099ff3e25f92593e9e...
> > >
> > >
TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kthelgason@webrtc.org,ht...
> > > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > > BUG=600399
> > >
> > > Review-Url: https://codereview.chromium.org/2651543002
> > > Cr-Commit-Position: refs/heads/master@{#445311}
> > > Committed:
https://chromium.googlesource.com/chromium/src/+/3f4ee1b009741853987773717ebc...
> >
> >
> > BUG=600399
> >
> > Review-Url: https://codereview.chromium.org/2645293002
> > Cr-Commit-Position: refs/heads/master@{#445358}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/2c39ea391c4df544e2f6162ae595...
> 
>
TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kjellander@chromium.org,...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=600399
> 
> Review-Url: https://codereview.chromium.org/2651643004
> Cr-Commit-Position: refs/heads/master@{#445680}
> Committed:
https://chromium.googlesource.com/chromium/src/+/95cc5f514856c42df9287ca5f68e...

TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kjellander@chromium.org,...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=600399
==========

[commit-bot: I haz the power, 2017-01-26 09:29:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 09:29:33]

Dry run: This issue passed the CQ dry run.

[hta - Chromium, 2017-01-27 09:58:55]

This should be ready for review.

[hta - Chromium, 2017-01-27 09:58:55]

This should be ready for review.

[kjellander_chromium, 2017-01-27 11:02:14]

lgtm

[hta - Chromium, 2017-01-27 11:29:05]

The CQ bit was checked by hta@chromium.org

[commit-bot: I haz the power, 2017-01-27 11:29:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 12:30:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485516545368210,
"parent_rev": "04445b9ca99cf8248808d81df014e389ad75efc2", "commit_rev":
"2529431f34dfdfef0d698b5ab35a5c9cb9ff566a"}

[commit-bot: I haz the power, 2017-01-27 12:30:32]

Description was changed from

==========
Reland of Add assembly for x86 to OpenH264 encoder (patchset #1 id:1 of
https://codereview.chromium.org/2651643004/ )

Reason for revert:
Disabling assembly for MSAN build.

Original issue's description:
> Revert of Add assembly for x86 to OpenH264 encoder (patchset #2 id:40001 of
https://codereview.chromium.org/2645293002/ )
> 
> Reason for revert:
> Causes linux_msan to flake about uninitialized value, this warning needs to be
ignored before re-landing. Example:
https://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/16972
> 
> The address of the uninitialized value is used when calling a function through
a function pointer. The function writes to this value so it's safe, but
linux_msan doesn't know that.
> 
> Original issue's description:
> > Reland of Add assembly for x86 to OpenH264 encoder (patchset #1 id:1 of
https://codereview.chromium.org/2651543002/ )
> >
> > Reason for revert:
> > Reland
> >
> > Original issue's description:
> > > Revert of Add assembly for x86 to OpenH264 encoder (patchset #5 id:80001
of https://codereview.chromium.org/2585733002/ )
> > >
> > > Reason for revert:
> > > This broke Chrome OS builders:
> > >
> > >
https://uberchromegw.corp.google.com/i/chromeos/builders/veyron_minnie-chrome...
> > >
> > >
> > > Original issue's description:
> > > > Add assembly for x86 to OpenH264 encoder
> > > >
> > > > On Linux on a build workstation, these changes seem to give around 2.5x
faster encoding (frame encode time in test goes from ~25 to ~9 ms)
> > > >
> > > > We do expect alerts from our performance bots when this lands.
> > > >
> > > > Credit: These build changes were written by brian@highfive.com aka
bbaldino@gmail.com.
> > > >
> > > > BUG=600399
> > > >
> > > > Review-Url: https://codereview.chromium.org/2585733002
> > > > Cr-Commit-Position: refs/heads/master@{#445033}
> > > > Committed:
https://chromium.googlesource.com/chromium/src/+/6d1501f500099ff3e25f92593e9e...
> > >
> > >
TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kthelgason@webrtc.org,ht...
> > > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > > BUG=600399
> > >
> > > Review-Url: https://codereview.chromium.org/2651543002
> > > Cr-Commit-Position: refs/heads/master@{#445311}
> > > Committed:
https://chromium.googlesource.com/chromium/src/+/3f4ee1b009741853987773717ebc...
> >
> >
> > BUG=600399
> >
> > Review-Url: https://codereview.chromium.org/2645293002
> > Cr-Commit-Position: refs/heads/master@{#445358}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/2c39ea391c4df544e2f6162ae595...
> 
>
TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kjellander@chromium.org,...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=600399
> 
> Review-Url: https://codereview.chromium.org/2651643004
> Cr-Commit-Position: refs/heads/master@{#445680}
> Committed:
https://chromium.googlesource.com/chromium/src/+/95cc5f514856c42df9287ca5f68e...

TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kjellander@chromium.org,...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=600399
==========

to

==========
Reland of Add assembly for x86 to OpenH264 encoder (patchset #1 id:1 of
https://codereview.chromium.org/2651643004/ )

Reason for revert:
Disabling assembly for MSAN build.

Original issue's description:
> Revert of Add assembly for x86 to OpenH264 encoder (patchset #2 id:40001 of
https://codereview.chromium.org/2645293002/ )
> 
> Reason for revert:
> Causes linux_msan to flake about uninitialized value, this warning needs to be
ignored before re-landing. Example:
https://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/16972
> 
> The address of the uninitialized value is used when calling a function through
a function pointer. The function writes to this value so it's safe, but
linux_msan doesn't know that.
> 
> Original issue's description:
> > Reland of Add assembly for x86 to OpenH264 encoder (patchset #1 id:1 of
https://codereview.chromium.org/2651543002/ )
> >
> > Reason for revert:
> > Reland
> >
> > Original issue's description:
> > > Revert of Add assembly for x86 to OpenH264 encoder (patchset #5 id:80001
of https://codereview.chromium.org/2585733002/ )
> > >
> > > Reason for revert:
> > > This broke Chrome OS builders:
> > >
> > >
https://uberchromegw.corp.google.com/i/chromeos/builders/veyron_minnie-chrome...
> > >
> > >
> > > Original issue's description:
> > > > Add assembly for x86 to OpenH264 encoder
> > > >
> > > > On Linux on a build workstation, these changes seem to give around 2.5x
faster encoding (frame encode time in test goes from ~25 to ~9 ms)
> > > >
> > > > We do expect alerts from our performance bots when this lands.
> > > >
> > > > Credit: These build changes were written by brian@highfive.com aka
bbaldino@gmail.com.
> > > >
> > > > BUG=600399
> > > >
> > > > Review-Url: https://codereview.chromium.org/2585733002
> > > > Cr-Commit-Position: refs/heads/master@{#445033}
> > > > Committed:
https://chromium.googlesource.com/chromium/src/+/6d1501f500099ff3e25f92593e9e...
> > >
> > >
TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kthelgason@webrtc.org,ht...
> > > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > > BUG=600399
> > >
> > > Review-Url: https://codereview.chromium.org/2651543002
> > > Cr-Commit-Position: refs/heads/master@{#445311}
> > > Committed:
https://chromium.googlesource.com/chromium/src/+/3f4ee1b009741853987773717ebc...
> >
> >
> > BUG=600399
> >
> > Review-Url: https://codereview.chromium.org/2645293002
> > Cr-Commit-Position: refs/heads/master@{#445358}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/2c39ea391c4df544e2f6162ae595...
> 
>
TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kjellander@chromium.org,...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=600399
> 
> Review-Url: https://codereview.chromium.org/2651643004
> Cr-Commit-Position: refs/heads/master@{#445680}
> Committed:
https://chromium.googlesource.com/chromium/src/+/95cc5f514856c42df9287ca5f68e...

TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kjellander@chromium.org,...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=600399

Review-Url: https://codereview.chromium.org/2651183003
Cr-Commit-Position: refs/heads/master@{#446649}
Committed:
https://chromium.googlesource.com/chromium/src/+/2529431f34dfdfef0d698b5ab35a...
==========

[commit-bot: I haz the power, 2017-01-27 12:30:33]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2529431f34dfdfef0d698b5ab35a...

[hbos_chromium, 2017-01-27 12:34:16]

On 2017/01/27 12:30:33, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:40001) as
>
https://chromium.googlesource.com/chromium/src/+/2529431f34dfdfef0d698b5ab35a...

Godspeed.