Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2645293002:
Reland of Add assembly for x86 to OpenH264 encoder (Closed)
|
Created:
3 years, 11 months ago by hta - Chromium Modified:
3 years, 10 months ago Reviewers:
ehmaldonado_chromium, kjellander_chromium, haraken, kthelgason_chromium, mflodman_chromium_OOO CC:
chromium-reviews, brian4 Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReland of Add assembly for x86 to OpenH264 encoder (patchset #1 id:1 of https://codereview.chromium.org/2651543002/ )
Reason for revert:
Reland
Original issue's description:
> Revert of Add assembly for x86 to OpenH264 encoder (patchset #5 id:80001 of https://codereview.chromium.org/2585733002/ )
>
> Reason for revert:
> This broke Chrome OS builders:
>
> https://uberchromegw.corp.google.com/i/chromeos/builders/veyron_minnie-chrome-pfq/builds/669/steps/BuildPackages/logs/stdio
>
>
> Original issue's description:
> > Add assembly for x86 to OpenH264 encoder
> >
> > On Linux on a build workstation, these changes seem to give around 2.5x faster encoding (frame encode time in test goes from ~25 to ~9 ms)
> >
> > We do expect alerts from our performance bots when this lands.
> >
> > Credit: These build changes were written by brian@highfive.com aka bbaldino@gmail.com.
> >
> > BUG=600399
> >
> > Review-Url: https://codereview.chromium.org/2585733002
> > Cr-Commit-Position: refs/heads/master@{#445033}
> > Committed: https://chromium.googlesource.com/chromium/src/+/6d1501f500099ff3e25f92593e9efcb27d352252
>
> TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kthelgason@webrtc.org,hta@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=600399
>
> Review-Url: https://codereview.chromium.org/2651543002
> Cr-Commit-Position: refs/heads/master@{#445311}
> Committed: https://chromium.googlesource.com/chromium/src/+/3f4ee1b009741853987773717ebc2f22c5f0c60b
BUG=600399
Review-Url: https://codereview.chromium.org/2645293002
Cr-Commit-Position: refs/heads/master@{#445358}
Committed: https://chromium.googlesource.com/chromium/src/+/2c39ea391c4df544e2f6162ae595083ce2d04e99
Patch Set 1 #
Total comments: 1
Patch Set 2 : Moved CPU guard from target to surrounding if #Messages
Total messages: 29 (20 generated)
Created Reland of Add assembly for x86 to OpenH264 encoder
https://codereview.chromium.org/2645293002/diff/1/third_party/openh264/BUILD.gn File third_party/openh264/BUILD.gn (right): https://codereview.chromium.org/2645293002/diff/1/third_party/openh264/BUILD.... third_party/openh264/BUILD.gn:41: assert(target_cpu == "x86" || target_cpu == "x64", This won't work for Linux ARM configurations. Can you add these into the condition above as well?
On 2017/01/23 08:17:59, kjellander_chromium wrote: > https://codereview.chromium.org/2645293002/diff/1/third_party/openh264/BUILD.gn > File third_party/openh264/BUILD.gn (right): > > https://codereview.chromium.org/2645293002/diff/1/third_party/openh264/BUILD.... > third_party/openh264/BUILD.gn:41: assert(target_cpu == "x86" || target_cpu == > "x64", > This won't work for Linux ARM configurations. Can you add these into the > condition above as well? Oops, didn't think the review message would go out now. I'll fix before trying to land.
On 2017/01/23 08:20:46, hta - Chromium wrote: > On 2017/01/23 08:17:59, kjellander_chromium wrote: > > > https://codereview.chromium.org/2645293002/diff/1/third_party/openh264/BUILD.gn > > File third_party/openh264/BUILD.gn (right): > > > > > https://codereview.chromium.org/2645293002/diff/1/third_party/openh264/BUILD.... > > third_party/openh264/BUILD.gn:41: assert(target_cpu == "x86" || target_cpu == > > "x64", > > This won't work for Linux ARM configurations. Can you add these into the > > condition above as well? > > Oops, didn't think the review message would go out now. I'll fix before trying > to land. Yeah, it's a bit annoying that it does since you usually want to prepare a PS#2 with changes before relanding (and/or at least change the CL description).
The CQ bit was checked by hta@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Reland of Add assembly for x86 to OpenH264 encoder (patchset #1 id:1 of https://codereview.chromium.org/2651543002/ ) Reason for revert: Reland Original issue's description: > Revert of Add assembly for x86 to OpenH264 encoder (patchset #5 id:80001 of https://codereview.chromium.org/2585733002/ ) > > Reason for revert: > This broke Chrome OS builders: > > https://uberchromegw.corp.google.com/i/chromeos/builders/veyron_minnie-chrome... > > > Original issue's description: > > Add assembly for x86 to OpenH264 encoder > > > > On Linux on a build workstation, these changes seem to give around 2.5x faster encoding (frame encode time in test goes from ~25 to ~9 ms) > > > > We do expect alerts from our performance bots when this lands. > > > > Credit: These build changes were written by brian@highfive.com aka bbaldino@gmail.com. > > > > BUG=600399 > > > > Review-Url: https://codereview.chromium.org/2585733002 > > Cr-Commit-Position: refs/heads/master@{#445033} > > Committed: https://chromium.googlesource.com/chromium/src/+/6d1501f500099ff3e25f92593e9e... > > TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kthelgason@webrtc.org,ht... > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=600399 > > Review-Url: https://codereview.chromium.org/2651543002 > Cr-Commit-Position: refs/heads/master@{#445311} > Committed: https://chromium.googlesource.com/chromium/src/+/3f4ee1b009741853987773717ebc... TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kthelgason@webrtc.org,kj... # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=600399 ========== to ========== Reland of Add assembly for x86 to OpenH264 encoder (patchset #1 id:1 of https://codereview.chromium.org/2651543002/ ) Reason for revert: Reland Original issue's description: > Revert of Add assembly for x86 to OpenH264 encoder (patchset #5 id:80001 of https://codereview.chromium.org/2585733002/ ) > > Reason for revert: > This broke Chrome OS builders: > > https://uberchromegw.corp.google.com/i/chromeos/builders/veyron_minnie-chrome... > > > Original issue's description: > > Add assembly for x86 to OpenH264 encoder > > > > On Linux on a build workstation, these changes seem to give around 2.5x faster encoding (frame encode time in test goes from ~25 to ~9 ms) > > > > We do expect alerts from our performance bots when this lands. > > > > Credit: These build changes were written by brian@highfive.com aka bbaldino@gmail.com. > > > > BUG=600399 > > > > Review-Url: https://codereview.chromium.org/2585733002 > > Cr-Commit-Position: refs/heads/master@{#445033} > > Committed: https://chromium.googlesource.com/chromium/src/+/6d1501f500099ff3e25f92593e9e... > > TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kthelgason@webrtc.org,ht... > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=600399 > > Review-Url: https://codereview.chromium.org/2651543002 > Cr-Commit-Position: refs/heads/master@{#445311} > Committed: https://chromium.googlesource.com/chromium/src/+/3f4ee1b009741853987773717ebc... TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kthelgason@webrtc.org,kj... # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=600399 ==========
hta@chromium.org changed reviewers: - kthelgason@webrtc.org
The CQ bit was checked by hta@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Reland of Add assembly for x86 to OpenH264 encoder (patchset #1 id:1 of https://codereview.chromium.org/2651543002/ ) Reason for revert: Reland Original issue's description: > Revert of Add assembly for x86 to OpenH264 encoder (patchset #5 id:80001 of https://codereview.chromium.org/2585733002/ ) > > Reason for revert: > This broke Chrome OS builders: > > https://uberchromegw.corp.google.com/i/chromeos/builders/veyron_minnie-chrome... > > > Original issue's description: > > Add assembly for x86 to OpenH264 encoder > > > > On Linux on a build workstation, these changes seem to give around 2.5x faster encoding (frame encode time in test goes from ~25 to ~9 ms) > > > > We do expect alerts from our performance bots when this lands. > > > > Credit: These build changes were written by brian@highfive.com aka bbaldino@gmail.com. > > > > BUG=600399 > > > > Review-Url: https://codereview.chromium.org/2585733002 > > Cr-Commit-Position: refs/heads/master@{#445033} > > Committed: https://chromium.googlesource.com/chromium/src/+/6d1501f500099ff3e25f92593e9e... > > TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kthelgason@webrtc.org,ht... > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=600399 > > Review-Url: https://codereview.chromium.org/2651543002 > Cr-Commit-Position: refs/heads/master@{#445311} > Committed: https://chromium.googlesource.com/chromium/src/+/3f4ee1b009741853987773717ebc... TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kthelgason@webrtc.org,kj... # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=600399 ========== to ========== Reland of Add assembly for x86 to OpenH264 encoder (patchset #1 id:1 of https://codereview.chromium.org/2651543002/ ) Reason for revert: Reland Original issue's description: > Revert of Add assembly for x86 to OpenH264 encoder (patchset #5 id:80001 of https://codereview.chromium.org/2585733002/ ) > > Reason for revert: > This broke Chrome OS builders: > > https://uberchromegw.corp.google.com/i/chromeos/builders/veyron_minnie-chrome... > > > Original issue's description: > > Add assembly for x86 to OpenH264 encoder > > > > On Linux on a build workstation, these changes seem to give around 2.5x faster encoding (frame encode time in test goes from ~25 to ~9 ms) > > > > We do expect alerts from our performance bots when this lands. > > > > Credit: These build changes were written by brian@highfive.com aka bbaldino@gmail.com. > > > > BUG=600399 > > > > Review-Url: https://codereview.chromium.org/2585733002 > > Cr-Commit-Position: refs/heads/master@{#445033} > > Committed: https://chromium.googlesource.com/chromium/src/+/6d1501f500099ff3e25f92593e9e... > > TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kthelgason@webrtc.org,ht... > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=600399 > > Review-Url: https://codereview.chromium.org/2651543002 > Cr-Commit-Position: refs/heads/master@{#445311} > Committed: https://chromium.googlesource.com/chromium/src/+/3f4ee1b009741853987773717ebc... BUG=600399 ==========
The CQ bit was checked by hta@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I think this is ready for review.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hta@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485169344306950,
"parent_rev": "560d55d7d2122116b456e157f761eaa252246e4f", "commit_rev":
"2c39ea391c4df544e2f6162ae595083ce2d04e99"}
Message was sent while issue was closed.
Description was changed from ========== Reland of Add assembly for x86 to OpenH264 encoder (patchset #1 id:1 of https://codereview.chromium.org/2651543002/ ) Reason for revert: Reland Original issue's description: > Revert of Add assembly for x86 to OpenH264 encoder (patchset #5 id:80001 of https://codereview.chromium.org/2585733002/ ) > > Reason for revert: > This broke Chrome OS builders: > > https://uberchromegw.corp.google.com/i/chromeos/builders/veyron_minnie-chrome... > > > Original issue's description: > > Add assembly for x86 to OpenH264 encoder > > > > On Linux on a build workstation, these changes seem to give around 2.5x faster encoding (frame encode time in test goes from ~25 to ~9 ms) > > > > We do expect alerts from our performance bots when this lands. > > > > Credit: These build changes were written by brian@highfive.com aka bbaldino@gmail.com. > > > > BUG=600399 > > > > Review-Url: https://codereview.chromium.org/2585733002 > > Cr-Commit-Position: refs/heads/master@{#445033} > > Committed: https://chromium.googlesource.com/chromium/src/+/6d1501f500099ff3e25f92593e9e... > > TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kthelgason@webrtc.org,ht... > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=600399 > > Review-Url: https://codereview.chromium.org/2651543002 > Cr-Commit-Position: refs/heads/master@{#445311} > Committed: https://chromium.googlesource.com/chromium/src/+/3f4ee1b009741853987773717ebc... BUG=600399 ========== to ========== Reland of Add assembly for x86 to OpenH264 encoder (patchset #1 id:1 of https://codereview.chromium.org/2651543002/ ) Reason for revert: Reland Original issue's description: > Revert of Add assembly for x86 to OpenH264 encoder (patchset #5 id:80001 of https://codereview.chromium.org/2585733002/ ) > > Reason for revert: > This broke Chrome OS builders: > > https://uberchromegw.corp.google.com/i/chromeos/builders/veyron_minnie-chrome... > > > Original issue's description: > > Add assembly for x86 to OpenH264 encoder > > > > On Linux on a build workstation, these changes seem to give around 2.5x faster encoding (frame encode time in test goes from ~25 to ~9 ms) > > > > We do expect alerts from our performance bots when this lands. > > > > Credit: These build changes were written by brian@highfive.com aka bbaldino@gmail.com. > > > > BUG=600399 > > > > Review-Url: https://codereview.chromium.org/2585733002 > > Cr-Commit-Position: refs/heads/master@{#445033} > > Committed: https://chromium.googlesource.com/chromium/src/+/6d1501f500099ff3e25f92593e9e... > > TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kthelgason@webrtc.org,ht... > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=600399 > > Review-Url: https://codereview.chromium.org/2651543002 > Cr-Commit-Position: refs/heads/master@{#445311} > Committed: https://chromium.googlesource.com/chromium/src/+/3f4ee1b009741853987773717ebc... BUG=600399 Review-Url: https://codereview.chromium.org/2645293002 Cr-Commit-Position: refs/heads/master@{#445358} Committed: https://chromium.googlesource.com/chromium/src/+/2c39ea391c4df544e2f6162ae595... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/2c39ea391c4df544e2f6162ae595...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in https://codereview.chromium.org/2651643004/ by hbos@chromium.org. The reason for reverting is: Causes linux_msan to flake about uninitialized value, this warning needs to be ignored before re-landing. Example: https://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/16972 The address of the uninitialized value is used when calling a function through a function pointer. The function writes to this value so it's safe, but linux_msan doesn't know that..
Message was sent while issue was closed.
Description was changed from ========== Reland of Add assembly for x86 to OpenH264 encoder (patchset #1 id:1 of https://codereview.chromium.org/2651543002/ ) Reason for revert: Reland Original issue's description: > Revert of Add assembly for x86 to OpenH264 encoder (patchset #5 id:80001 of https://codereview.chromium.org/2585733002/ ) > > Reason for revert: > This broke Chrome OS builders: > > https://uberchromegw.corp.google.com/i/chromeos/builders/veyron_minnie-chrome... > > > Original issue's description: > > Add assembly for x86 to OpenH264 encoder > > > > On Linux on a build workstation, these changes seem to give around 2.5x faster encoding (frame encode time in test goes from ~25 to ~9 ms) > > > > We do expect alerts from our performance bots when this lands. > > > > Credit: These build changes were written by brian@highfive.com aka bbaldino@gmail.com. > > > > BUG=600399 > > > > Review-Url: https://codereview.chromium.org/2585733002 > > Cr-Commit-Position: refs/heads/master@{#445033} > > Committed: https://chromium.googlesource.com/chromium/src/+/6d1501f500099ff3e25f92593e9e... > > TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kthelgason@webrtc.org,ht... > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=600399 > > Review-Url: https://codereview.chromium.org/2651543002 > Cr-Commit-Position: refs/heads/master@{#445311} > Committed: https://chromium.googlesource.com/chromium/src/+/3f4ee1b009741853987773717ebc... BUG=600399 Review-Url: https://codereview.chromium.org/2645293002 Cr-Commit-Position: refs/heads/master@{#445358} Committed: https://chromium.googlesource.com/chromium/src/+/2c39ea391c4df544e2f6162ae595... ========== to ========== Reland of Add assembly for x86 to OpenH264 encoder (patchset #1 id:1 of https://codereview.chromium.org/2651543002/ ) Reason for revert: Reland Original issue's description: > Revert of Add assembly for x86 to OpenH264 encoder (patchset #5 id:80001 of https://codereview.chromium.org/2585733002/ ) > > Reason for revert: > This broke Chrome OS builders: > > https://uberchromegw.corp.google.com/i/chromeos/builders/veyron_minnie-chrome... > > > Original issue's description: > > Add assembly for x86 to OpenH264 encoder > > > > On Linux on a build workstation, these changes seem to give around 2.5x faster encoding (frame encode time in test goes from ~25 to ~9 ms) > > > > We do expect alerts from our performance bots when this lands. > > > > Credit: These build changes were written by brian@highfive.com aka bbaldino@gmail.com. > > > > BUG=600399 > > > > Review-Url: https://codereview.chromium.org/2585733002 > > Cr-Commit-Position: refs/heads/master@{#445033} > > Committed: https://chromium.googlesource.com/chromium/src/+/6d1501f500099ff3e25f92593e9e... > > TBR=kthelgason@chromium.org,ehmaldonado@chromium.org,kthelgason@webrtc.org,ht... > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=600399 > > Review-Url: https://codereview.chromium.org/2651543002 > Cr-Commit-Position: refs/heads/master@{#445311} > Committed: https://chromium.googlesource.com/chromium/src/+/3f4ee1b009741853987773717ebc... BUG=600399 Review-Url: https://codereview.chromium.org/2645293002 Cr-Commit-Position: refs/heads/master@{#445358} Committed: https://chromium.googlesource.com/chromium/src/+/2c39ea391c4df544e2f6162ae595... ==========
Message was sent while issue was closed.
wez@chromium.org changed reviewers: + mflodman@chromium.org |
