[MD settings] rename advancedSubmenu id

[MD settings] rename advancedSubmenu id

This CL changes the name of the #advancedSubmenu to reduce confusion
with the #advancedPage.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2651103003
Cr-Commit-Position: refs/heads/master@{#446152}
Committed: https://chromium.googlesource.com/chromium/src/+/4165f8b808fa119cc593dafb257de78bc266d02c

[dschuyler, 2017-01-25 02:18:10]

Description was changed from

==========
[MD settings] rename advancedSubmenu id

This CL changes the name of the #advancedSubmenu to reduce confusion
with the #advancedPage.

BUG=None
==========

to

==========
[MD settings] rename advancedSubmenu id

This CL changes the name of the #advancedSubmenu to reduce confusion
with the #advancedPage.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-01-25 02:18:12]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[dschuyler, 2017-01-25 02:19:13]

dschuyler@chromium.org changed reviewers:
+ tommycli@chromium.org

[commit-bot: I haz the power, 2017-01-25 02:19:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 03:30:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 03:30:02]

Dry run: This issue passed the CQ dry run.

[tommycli, 2017-01-25 22:33:39]

lgtm. may be worth doing the same thing for #basicPage, can be separate CL,
thanks!

[dschuyler, 2017-01-25 22:50:16]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2017-01-25 22:51:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 23:00:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485384616553290, "parent_rev":
"55cd9ef40d390ea5a39089d4b18ea8fe78de5eb8", "commit_rev":
"4165f8b808fa119cc593dafb257de78bc266d02c"}

[commit-bot: I haz the power, 2017-01-25 23:01:12]

Description was changed from

==========
[MD settings] rename advancedSubmenu id

This CL changes the name of the #advancedSubmenu to reduce confusion
with the #advancedPage.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] rename advancedSubmenu id

This CL changes the name of the #advancedSubmenu to reduce confusion
with the #advancedPage.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2651103003
Cr-Commit-Position: refs/heads/master@{#446152}
Committed:
https://chromium.googlesource.com/chromium/src/+/4165f8b808fa119cc593dafb257d...
==========

[commit-bot: I haz the power, 2017-01-25 23:01:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4165f8b808fa119cc593dafb257d...

[wOxxOm, 2017-01-26 20:39:07]

The patch introduces a bug:
1. open chrome://md-settings
2. click hamburger icon on the top left to open the sidebar
3. click "Advanced"

EXPECTED: the sidebar stays open, the Advanced items appear in the sidebar
ACTUAL:   the sidebar closes

Reverting the patch locally fixes the bug.

[dschuyler, 2017-01-26 21:44:33]

On 2017/01/26 20:39:07, wOxxOm wrote:
> The patch introduces a bug:
> 1. open chrome://md-settings
> 2. click hamburger icon on the top left to open the sidebar
> 3. click "Advanced"
> 
> EXPECTED: the sidebar stays open, the Advanced items appear in the sidebar
> ACTUAL:   the sidebar closes
> 
> Reverting the patch locally fixes the bug.

Thanks! There's a fix in CL 2659593004.