Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8883)

Unified Diff: chrome/test/data/webui/settings/settings_menu_test.js

Issue 2651103003: [MD settings] rename advancedSubmenu id (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/settings_menu_test.js
diff --git a/chrome/test/data/webui/settings/settings_menu_test.js b/chrome/test/data/webui/settings/settings_menu_test.js
index 6381eb58249fd14dc60356c1b91c307372321339..ed9d2a03552d2b3bf1a5571c5f2de9d82c9b6c45 100644
--- a/chrome/test/data/webui/settings/settings_menu_test.js
+++ b/chrome/test/data/webui/settings/settings_menu_test.js
@@ -22,32 +22,32 @@ cr.define('settings_menu', function() {
assertFalse(settingsMenu.advancedOpened);
settingsMenu.advancedOpened = true;
Polymer.dom.flush();
- assertTrue(settingsMenu.$.advancedPage.opened);
+ assertTrue(settingsMenu.$.advancedSubmenu.opened);
settingsMenu.advancedOpened = false;
Polymer.dom.flush();
- assertFalse(settingsMenu.$.advancedPage.opened);
+ assertFalse(settingsMenu.$.advancedSubmenu.opened);
});
test('tapAdvanced', function() {
assertFalse(settingsMenu.advancedOpened);
- var advancedTrigger = settingsMenu.$$('#advancedPage .menu-trigger');
+ var advancedTrigger = settingsMenu.$$('#advancedSubmenu .menu-trigger');
assertTrue(!!advancedTrigger);
MockInteractions.tap(advancedTrigger);
Polymer.dom.flush();
- assertTrue(settingsMenu.$.advancedPage.opened);
+ assertTrue(settingsMenu.$.advancedSubmenu.opened);
MockInteractions.tap(advancedTrigger);
Polymer.dom.flush();
- assertFalse(settingsMenu.$.advancedPage.opened);
+ assertFalse(settingsMenu.$.advancedSubmenu.opened);
});
test('upAndDownIcons', function() {
// There should be different icons for a top level menu being open
// vs. being closed. E.g. arrow-drop-up and arrow-drop-down.
- var ironIconElement = settingsMenu.$.advancedPage.querySelector(
+ var ironIconElement = settingsMenu.$.advancedSubmenu.querySelector(
'.menu-trigger iron-icon');
assertTrue(!!ironIconElement);
@@ -63,9 +63,9 @@ cr.define('settings_menu', function() {
test('openResetSection', function() {
settingsMenu.currentRoute = settings.Route.RESET;
- var advancedPage = settingsMenu.$.advancedPage;
+ var advancedSubmenu = settingsMenu.$.advancedSubmenu;
assertEquals('/reset',
- advancedPage.querySelector('paper-menu').selected);
+ advancedSubmenu.querySelector('paper-menu').selected);
});
// Test that navigating via the paper menu always clears the current

Powered by Google App Engine
This is Rietveld 408576698