Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2651053004: Remove associated interface registration from ChannelProxy (Closed)

Created:
3 years, 11 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Remove associated interface registration from ChannelProxy ChannelProxy already delegates incoming associated interface requests to its Listener if they weren't handled by the Channel. We use this instead of having ChannelProxy register UI-thread-posting binders on the Channel itself. It's simpler and safer this way. This is a reland of the previous merge, now with 100% fewer compile failures! BUG=683773 R=jam@chromium.org Review-Url: https://codereview.chromium.org/2653973002 Cr-Commit-Position: refs/heads/master@{#445886} (cherry picked from commit 70bbb59493f1111361e3b1bedd04a14fedb334f4) Review-Url: https://codereview.chromium.org/2651053004 . Cr-Commit-Position: refs/branch-heads/2987@{#92} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/3594a5c4754dfd0d80df18d05bf5b6c94193d781

Patch Set 1 #

Patch Set 2 : let's try that again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -108 lines) Patch
M content/browser/renderer_host/render_process_host_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +15 lines, -11 lines 0 comments Download
M content/child/child_thread_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/child/child_thread_impl.cc View 3 chunks +14 lines, -10 lines 0 comments Download
M content/common/associated_interface_registry_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/associated_interface_registry_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download
M ipc/ipc_channel_mojo_unittest.cc View 9 chunks +31 lines, -24 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 4 chunks +5 lines, -28 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 4 chunks +3 lines, -28 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Ken Rockot(use gerrit already)
3 years, 11 months ago (2017-01-25 18:34:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3594a5c4754dfd0d80df18d05bf5b6c94193d781.

Powered by Google App Engine
This is Rietveld 408576698