Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2650953004: Check isText() when editing traverses layout tree for ::first-letter (Closed)

Created:
3 years, 11 months ago by kojii
Modified:
3 years, 11 months ago
Reviewers:
yosin_UTC9, eae
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check isText() when editing traverses layout tree for ::first-letter This patch checks isText() before toLayoutText() when editing traverses layout trees for ::first-letter pseudo elements. Normally, the first child of ::first-letter pseudo element is LayoutText. This patch checks if the assumption stands. BUG=684684 Review-Url: https://codereview.chromium.org/2650953004 Cr-Commit-Position: refs/heads/master@{#445986} Committed: https://chromium.googlesource.com/chromium/src/+/e29607bd33d91db8c58127eb6469fca2ad22c16a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp View 1 chunk +3 lines, -3 lines 1 comment Download

Messages

Total messages: 15 (9 generated)
kojii
PTAL.
3 years, 11 months ago (2017-01-25 08:11:49 UTC) #6
yosin_UTC9
lgtm w/ small nit https://codereview.chromium.org/2650953004/diff/1/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp File third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp (right): https://codereview.chromium.org/2650953004/diff/1/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp#newcode843 third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp:843: CHECK(firstLetter && firstLetter->isText()); Let's use ...
3 years, 11 months ago (2017-01-25 08:17:51 UTC) #7
kojii
On 2017/01/25 at 08:17:51, yosin wrote: > Let's use SECURITY_CHECK() Discussed offline, we're not clear ...
3 years, 11 months ago (2017-01-25 08:24:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650953004/1
3 years, 11 months ago (2017-01-25 09:06:44 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e29607bd33d91db8c58127eb6469fca2ad22c16a
3 years, 11 months ago (2017-01-25 09:27:31 UTC) #14
eae
3 years, 11 months ago (2017-01-25 17:19:45 UTC) #15
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698