third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp - Issue 2650953004: Check isText() when editing traverses layout tree for ::first-letter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

Issue 2650953004: Check isText() when editing traverses layout tree for ::first-letter (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

diff --git a/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp b/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

index 69bc7851635c2843cc2a421890729ff86b32017a..d6e369dfd1833d2e55b31c8b65dca5258b5d28e5 100644

--- a/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

+++ b/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

@@ -837,12 +837,12 @@ void TextIteratorAlgorithm<Strategy>::handleTextNodeFirstLetter(

return;

LayoutObject* firstLetter = pseudoLayoutObject->slowFirstChild();

- DCHECK(firstLetter);

- m_remainingTextBox = m_textBox;

- m_textBox = toLayoutText(firstLetter)->firstTextBox();

m_sortedTextBoxes.clear();

+ m_remainingTextBox = m_textBox;

+ CHECK(firstLetter && firstLetter->isText());

yosin_UTC9 2017/01/25 08:17:51 Let's use SECURITY_CHECK()

m_firstLetterText = toLayoutText(firstLetter);

+ m_textBox = m_firstLetterText->firstTextBox();

}

template <typename Strategy>

« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleUnits.cpp ('k') | no next file » | no next file with comments »