Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Issue 2650793004: When getting CC list during test import, ignore non-email-addresses. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When getting CC list during test import, ignore non-email-addresses. BUG=684026 Review-Url: https://codereview.chromium.org/2650793004 Cr-Commit-Position: refs/heads/master@{#445595} Committed: https://chromium.googlesource.com/chromium/src/+/2ec6488cbe9a932ea87c39e6ed201b0083a86ae9

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
qyearsley
This is meant to fix the current problem that the test importer is running into.
3 years, 11 months ago (2017-01-23 20:02:44 UTC) #2
jeffcarp
lgtm! https://codereview.chromium.org/2650793004/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (right): https://codereview.chromium.org/2650793004/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py#newcode394 third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:394: if not re.match(r'\S+@\S+', address): I read somewhere that ...
3 years, 11 months ago (2017-01-23 20:28:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650793004/20001
3 years, 11 months ago (2017-01-23 23:53:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650793004/20001
3 years, 11 months ago (2017-01-24 01:42:24 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 02:00:19 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2ec6488cbe9a932ea87c39e6ed20...

Powered by Google App Engine
This is Rietveld 408576698