Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

Issue 2650793004: When getting CC list during test import, ignore non-email-addresses. (Closed)
Patch Set: Rebased Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
index 1f3257ec9b6314f6d3d0e4cc04f082fe38141400..a839640a6f5912dd2947b0f551dd50b8b11d8f35 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
@@ -15,9 +15,10 @@ upload a CL, trigger try jobs, and make any changes that are required for
new failing tests before committing.
"""
-import logging
import argparse
import json
+import logging
+import re
from webkitpy.common.net.git_cl import GitCL
from webkitpy.common.webkit_finder import WebKitFinder
@@ -389,7 +390,11 @@ class DepsUpdater(object):
continue
test_dir = self.fs.dirname(test_path)
if test_dir in directory_to_owner:
- email_addresses.add(directory_to_owner[test_dir])
+ address = directory_to_owner[test_dir]
+ if not re.match(r'\S+@\S+', address):
+ _log.warning('%s appears not be an email address, skipping.', address)
+ continue
+ email_addresses.add(address)
return sorted(email_addresses)
def fetch_new_expectations_and_baselines(self):
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698