Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2650783004: SharedWorker: Remove unnecessary indirection in SharedWorkerMessageFilter (Closed)

Created:
3 years, 11 months ago by nhiroki
Modified:
3 years, 11 months ago
Reviewers:
horo
CC:
chromium-reviews, jam, kinuko+watch, darin-cc_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SharedWorker: Remove unnecessary indirection in SharedWorkerMessageFilter This is a cleanup CL and should not change behavior. BUG=612308 Review-Url: https://codereview.chromium.org/2650783004 Cr-Commit-Position: refs/heads/master@{#445665} Committed: https://chromium.googlesource.com/chromium/src/+/726b3a462b704b0398e5686dc67c6fbecfbf9353

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -132 lines) Patch
M content/browser/shared_worker/shared_worker_message_filter.h View 1 chunk +0 lines, -9 lines 0 comments Download
M content/browser/shared_worker/shared_worker_message_filter.cc View 2 chunks +29 lines, -69 lines 1 comment Download
M content/browser/shared_worker/shared_worker_service_impl.h View 1 chunk +23 lines, -23 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.cc View 6 chunks +27 lines, -31 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
nhiroki
PTAL, thanks! https://codereview.chromium.org/2650783004/diff/1/content/browser/shared_worker/shared_worker_message_filter.cc File content/browser/shared_worker/shared_worker_message_filter.cc (right): https://codereview.chromium.org/2650783004/diff/1/content/browser/shared_worker/shared_worker_message_filter.cc#newcode82 content/browser/shared_worker/shared_worker_message_filter.cc:82: IPC_MESSAGE_HANDLER(WorkerProcessHostMsg_AllowIndexedDB, OnAllowIndexedDB) I couldn't replace RequestFileSystemAccessSync and ...
3 years, 11 months ago (2017-01-24 04:31:27 UTC) #2
horo
lgtm
3 years, 11 months ago (2017-01-24 06:17:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650783004/1
3 years, 11 months ago (2017-01-24 06:22:41 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 06:27:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/726b3a462b704b0398e5686dc67c...

Powered by Google App Engine
This is Rietveld 408576698