Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: content/browser/shared_worker/shared_worker_service_impl.h

Issue 2650783004: SharedWorker: Remove unnecessary indirection in SharedWorkerMessageFilter (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/shared_worker/shared_worker_service_impl.h
diff --git a/content/browser/shared_worker/shared_worker_service_impl.h b/content/browser/shared_worker/shared_worker_service_impl.h
index 5baabd8dbd7c08ba1b0749f661eb4e8f66024286..952b42843fb1dec2f8c2eec33820f7ec345200c4 100644
--- a/content/browser/shared_worker/shared_worker_service_impl.h
+++ b/content/browser/shared_worker/shared_worker_service_impl.h
@@ -56,33 +56,33 @@ class CONTENT_EXPORT SharedWorkerServiceImpl
SharedWorkerMessageFilter* filter,
ResourceContext* resource_context,
const WorkerStoragePartitionId& partition_id);
- void ConnectToWorker(int route_id,
- int sent_message_port_id,
- SharedWorkerMessageFilter* filter);
- void DocumentDetached(unsigned long long document_id,
- SharedWorkerMessageFilter* filter);
- void WorkerContextClosed(int worker_route_id,
- SharedWorkerMessageFilter* filter);
- void WorkerContextDestroyed(int worker_route_id,
- SharedWorkerMessageFilter* filter);
- void WorkerReadyForInspection(int worker_route_id,
- SharedWorkerMessageFilter* filter);
- void WorkerScriptLoaded(int worker_route_id,
- SharedWorkerMessageFilter* filter);
- void WorkerScriptLoadFailed(int worker_route_id,
- SharedWorkerMessageFilter* filter);
- void WorkerConnected(int message_port_id,
+ void ConnectToWorker(SharedWorkerMessageFilter* filter,
+ int route_id,
+ int sent_message_port_id);
+ void DocumentDetached(SharedWorkerMessageFilter* filter,
+ unsigned long long document_id);
+ void WorkerContextClosed(SharedWorkerMessageFilter* filter,
+ int worker_route_id);
+ void WorkerContextDestroyed(SharedWorkerMessageFilter* filter,
+ int worker_route_id);
+ void WorkerReadyForInspection(SharedWorkerMessageFilter* filter,
+ int worker_route_id);
+ void WorkerScriptLoaded(SharedWorkerMessageFilter* filter,
+ int worker_route_id);
+ void WorkerScriptLoadFailed(SharedWorkerMessageFilter* filter,
+ int worker_route_id);
+ void WorkerConnected(SharedWorkerMessageFilter* filter,
+ int message_port_id,
+ int worker_route_id);
+ void AllowFileSystem(SharedWorkerMessageFilter* filter,
int worker_route_id,
- SharedWorkerMessageFilter* filter);
- void AllowFileSystem(int worker_route_id,
const GURL& url,
- IPC::Message* reply_msg,
- SharedWorkerMessageFilter* filter);
- void AllowIndexedDB(int worker_route_id,
+ IPC::Message* reply_msg);
+ void AllowIndexedDB(SharedWorkerMessageFilter* filter,
+ int worker_route_id,
const GURL& url,
const base::string16& name,
- bool* result,
- SharedWorkerMessageFilter* filter);
+ bool* result);
void OnSharedWorkerMessageFilterClosing(
SharedWorkerMessageFilter* filter);

Powered by Google App Engine
This is Rietveld 408576698