Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2650783002: [wrapper-tracing] Fix V8GCController::getRetainerInfos (Closed)

Created:
3 years, 11 months ago by Michael Lippautz
Modified:
3 years, 11 months ago
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[wrapper-tracing] Fix V8GCController::getRetainerInfos Fix issues introduced in a34d185b3e31187fb8aa16b700e5837e9636cba9 BUG=chromium:679724 TBR=haraken@chromium.org,jochen@chromium.org Review-Url: https://codereview.chromium.org/2650783002 Cr-Commit-Position: refs/heads/master@{#445489} Committed: https://chromium.googlesource.com/chromium/src/+/124f15acfc2ed99a2e163191e6b24ed5dedb103a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Michael Lippautz
The test coverage is actually be pretty good (see https://build.chromium.org/p/tryserver.v8/builders/v8_linux_blink_rel/builds/14526), but is only triggered once ...
3 years, 11 months ago (2017-01-23 18:28:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650783002/1
3 years, 11 months ago (2017-01-23 18:30:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/124f15acfc2ed99a2e163191e6b24ed5dedb103a
3 years, 11 months ago (2017-01-23 21:20:24 UTC) #9
haraken
3 years, 11 months ago (2017-01-23 23:51:15 UTC) #10
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698