Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

Issue 2650783002: [wrapper-tracing] Fix V8GCController::getRetainerInfos (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
index 99776e7788df252375e0feae48dca8cbaf82dfce..0f3ff9ccfa3ac425d6f5a9549c2e387825da9034 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
@@ -175,18 +175,18 @@ class CORE_EXPORT V8PerIsolateData {
TemporaryScriptWrappableVisitorScope(
v8::Isolate* isolate,
std::unique_ptr<ScriptWrappableVisitor> visitor)
- : m_isolate(isolate) {
- swapWithV8PerIsolateDataVisitor(visitor);
+ : m_isolate(isolate), m_savedVisitor(std::move(visitor)) {
+ swapWithV8PerIsolateDataVisitor(m_savedVisitor);
}
~TemporaryScriptWrappableVisitorScope() {
swapWithV8PerIsolateDataVisitor(m_savedVisitor);
}
- private:
- inline ScriptWrappableVisitor* currentVisitor(v8::Isolate* isolate) {
+ inline ScriptWrappableVisitor* currentVisitor() {
return V8PerIsolateData::from(m_isolate)->scriptWrappableVisitor();
}
+ private:
void swapWithV8PerIsolateDataVisitor(
std::unique_ptr<ScriptWrappableVisitor>&);

Powered by Google App Engine
This is Rietveld 408576698