Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 2650733002: Revert of Update json_schema_compiler to handle the Automation extension API (Closed)

Created:
3 years, 11 months ago by sebsg
Modified:
3 years, 11 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, jlklein+watch-closure_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, vitalyp+closure_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-closure_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update json_schema_compiler to handle the Automation extension API (patchset #12 id:220001 of https://codereview.chromium.org/2601333002/ ) Reason for revert: interactive_uitests failing for 50 times in a row https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29?numbuilds=100 see crbug.com/683915 Original issue's description: > Update json_schema_compiler to handle the Automation extension API > > This allows the automation externs file to be fully autogenerated. > > Lots of tweaks to ChromeVox were required since we've been working with a > hand-tweaked externs file for a while. > > BUG=none > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2601333002 > Cr-Commit-Position: refs/heads/master@{#445146} > Committed: https://chromium.googlesource.com/chromium/src/+/f1cbfff18b19ff99310ffbfb94ca75462da7a859 TBR=dbeam@chromium.org,dtseng@chromium.org,rdevlin.cronin@chromium.org,dmazzoni@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=683915 Review-Url: https://codereview.chromium.org/2650733002 Cr-Commit-Position: refs/heads/master@{#445428} Committed: https://chromium.googlesource.com/chromium/src/+/8f4bf2e0d584f7b56059629037d714bf9d4b5abf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1267 lines, -1961 lines) Patch
M chrome/browser/resources/chromeos/chromevox/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_object_constructor_installer.js View 1 chunk +37 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js View 18 chunks +92 lines, -93 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 9 chunks +18 lines, -21 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 19 chunks +27 lines, -27 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js View 9 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js View 11 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs View 3 chunks +8 lines, -8 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/cvox2/background/custom_automation_event.js View 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 16 chunks +59 lines, -73 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js View 6 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/find_handler.js View 3 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js View 4 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/media_automation_handler.js View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 13 chunks +33 lines, -38 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/tabs_automation_handler.js View 3 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/tree_walker.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js View 3 chunks +12 lines, -12 lines 0 comments Download
M chrome/common/extensions/api/automation.idl View 6 chunks +56 lines, -162 lines 0 comments Download
M chrome/renderer/extensions/automation_internal_custom_bindings.cc View 3 chunks +30 lines, -8 lines 0 comments Download
M chrome/renderer/resources/extensions/automation/automation_node.js View 10 chunks +29 lines, -18 lines 0 comments Download
M chrome/renderer/resources/extensions/automation_custom_bindings.js View 6 chunks +18 lines, -7 lines 0 comments Download
M chrome/test/data/extensions/api_test/active_tab/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/desktop/actions.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/desktop/desktop.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/desktop/focus_views.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/desktop/load_tabs.js View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/generated/generated_trees.js View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/actions.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/attributes.js View 1 chunk +1 line, -9 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/bounds_for_range.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/document_selection.js View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/events.js View 4 chunks +16 lines, -16 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/find.js View 4 chunks +64 lines, -80 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/image_data.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/line_start_offsets.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/location.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/location2.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/sanity_check.js View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/closure_compiler/externs/automation.js View 4 chunks +614 lines, -1088 lines 0 comments Download
M tools/json_schema_compiler/idl_schema.py View 3 chunks +3 lines, -12 lines 0 comments Download
M tools/json_schema_compiler/idl_schema_test.py View 2 chunks +1 line, -6 lines 0 comments Download
M tools/json_schema_compiler/js_externs_generator.py View 8 chunks +8 lines, -41 lines 0 comments Download
M tools/json_schema_compiler/js_externs_generator_test.py View 2 chunks +0 lines, -49 lines 0 comments Download
M tools/json_schema_compiler/js_util.py View 1 chunk +0 lines, -12 lines 0 comments Download
M tools/json_schema_compiler/model.py View 2 chunks +2 lines, -4 lines 0 comments Download
M ui/accessibility/PRESUBMIT.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
sebsg
Created Revert of Update json_schema_compiler to handle the Automation extension API
3 years, 11 months ago (2017-01-23 14:55:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650733002/1
3 years, 11 months ago (2017-01-23 14:55:58 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/353001)
3 years, 11 months ago (2017-01-23 14:57:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650733002/1
3 years, 11 months ago (2017-01-23 16:49:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650733002/1
3 years, 11 months ago (2017-01-23 18:58:13 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 19:13:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8f4bf2e0d584f7b56059629037d7...

Powered by Google App Engine
This is Rietveld 408576698