Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5043)

Unified Diff: chrome/renderer/resources/extensions/automation/automation_node.js

Issue 2650733002: Revert of Update json_schema_compiler to handle the Automation extension API (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/automation/automation_node.js
diff --git a/chrome/renderer/resources/extensions/automation/automation_node.js b/chrome/renderer/resources/extensions/automation/automation_node.js
index 15b722570a53cce1a08e750c559672d4226247d3..ae62b33316b469eb1bceb9be86e76a8c71ea0cc3 100644
--- a/chrome/renderer/resources/extensions/automation/automation_node.js
+++ b/chrome/renderer/resources/extensions/automation/automation_node.js
@@ -224,15 +224,9 @@
*/
var GetHtmlAttribute = requireNative('automationInternal').GetHtmlAttribute;
-/**
- * @param {number} axTreeID The id of the accessibility tree.
- * @param {number} nodeID The id of a node.
- * @return {automation.NameFromType} The source of the node's name.
- */
-var GetNameFrom = requireNative('automationInternal').GetNameFrom;
-
var lastError = require('lastError');
var logging = requireNative('logging');
+var schema = requireNative('automationInternal').GetSchemaAdditions();
var utils = require('utils');
/**
@@ -363,10 +357,6 @@
var indexInParent = GetIndexInParent(this.treeID, this.id);
return this.rootImpl.get(
GetChildIDAtIndex(parent.treeID, parent.id, indexInParent + 1));
- },
-
- get nameFrom() {
- return GetNameFrom(this.treeID, this.id);
},
doDefault: function() {
@@ -679,17 +669,23 @@
var stringAttributes = [
'accessKey',
+ 'action',
'ariaInvalidValue',
+ 'autoComplete',
'containerLiveRelevant',
'containerLiveStatus',
'description',
'display',
+ 'dropeffect',
+ 'help',
+ 'htmlTag',
'imageDataUrl',
'language',
'liveRelevant',
'liveStatus',
'name',
'placeholder',
+ 'shortcut',
'textInputType',
'url',
'value'];
@@ -697,16 +693,24 @@
var boolAttributes = [
'ariaReadonly',
'buttonMixed',
+ 'canSetValue',
+ 'canvasHasFallback',
'containerLiveAtomic',
'containerLiveBusy',
+ 'grabbed',
+ 'isAxTreeHost',
'liveAtomic',
- 'liveBusy'];
+ 'liveBusy',
+ 'updateLocationOnly'];
var intAttributes = [
'backgroundColor',
'color',
'colorValue',
+ 'descriptionFrom',
'hierarchicalLevel',
+ 'invalidState',
+ 'nameFrom',
'posInSet',
'scrollX',
'scrollXMax',
@@ -715,6 +719,7 @@
'scrollYMax',
'scrollYMin',
'setSize',
+ 'sortDirection',
'tableCellColumnIndex',
'tableCellColumnSpan',
'tableCellRowIndex',
@@ -723,8 +728,10 @@
'tableColumnIndex',
'tableRowCount',
'tableRowIndex',
+ 'textDirection',
'textSelEnd',
- 'textSelStart'];
+ 'textSelStart',
+ 'textStyle'];
var nodeRefAttributes = [
['activedescendantId', 'activeDescendant'],
@@ -732,9 +739,11 @@
['previousOnLineId', 'previousOnLine'],
['tableColumnHeaderId', 'tableColumnHeader'],
['tableHeaderId', 'tableHeader'],
- ['tableRowHeaderId', 'tableRowHeader']];
+ ['tableRowHeaderId', 'tableRowHeader'],
+ ['titleUiElement', 'titleUIElement']];
var intListAttributes = [
+ 'characterOffsets',
'lineBreaks',
'markerEnds',
'markerStarts',
@@ -743,15 +752,18 @@
'wordStarts'];
var nodeRefListAttributes = [
+ ['cellIds', 'cells'],
['controlsIds', 'controls'],
['describedbyIds', 'describedBy'],
['flowtoIds', 'flowTo'],
- ['labelledbyIds', 'labelledBy']];
+ ['labelledbyIds', 'labelledBy'],
+ ['uniqueCellIds', 'uniqueCells']];
var floatAttributes = [
'valueForRange',
'minValueForRange',
- 'maxValueForRange'];
+ 'maxValueForRange',
+ 'fontSize'];
var htmlAttributes = [
['type', 'inputType']];
@@ -1024,7 +1036,7 @@
},
destroy: function() {
- this.dispatchEvent('destroyed', 'none');
+ this.dispatchEvent(schema.EventType.destroyed, 'none');
for (var id in this.axNodeDataCache_)
this.remove(id);
this.detach();
@@ -1108,7 +1120,6 @@
'lineStartOffsets',
'root',
'htmlAttributes',
- 'nameFrom',
]),
});

Powered by Google App Engine
This is Rietveld 408576698