Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2650683002: Initially load new_tab.css with a timestamp for chrome://apps. (Closed)

Created:
3 years, 11 months ago by rune
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Initially load new_tab.css with a timestamp for chrome://apps. This is what incognito_tab.html already does. Changing the url to add a timestamp query on DOMContentLoaded caused a FoUC. BUG=681495 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2647653002 Cr-Commit-Position: refs/heads/master@{#445285} (cherry picked from commit babe852aafe34f62d5ac8fbfc252830b64eebeea) Review-Url: https://codereview.chromium.org/2650683002 . Cr-Commit-Position: refs/branch-heads/2987@{#18} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/1db7914d0f409e02b43ef2b2ad0a5a99e048c588

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/resources/ntp4/new_tab.html View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.js View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
rune
3 years, 11 months ago (2017-01-23 09:37:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1db7914d0f409e02b43ef2b2ad0a5a99e048c588.

Powered by Google App Engine
This is Rietveld 408576698