Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2647653002:
Initially load new_tab.css with a timestamp for chrome://apps. (Closed)
DescriptionInitially load new_tab.css with a timestamp for chrome://apps.
This is what incognito_tab.html already does. Changing the url to add a
timestamp query on DOMContentLoaded caused a FoUC.
BUG=681495
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2647653002
Cr-Commit-Position: refs/heads/master@{#445285}
Committed: https://chromium.googlesource.com/chromium/src/+/babe852aafe34f62d5ac8fbfc252830b64eebeea
Patch Set 1 #Patch Set 2 : Initially load new_tab.css with a timestamp for chrome://apps. #
Total comments: 5
Messages
Total messages: 20 (12 generated)
Description was changed from ========== Hack to force active stylesheet update for chrome://apps. *** NOT FOR LANDING *** This is not an acceptable solution, but illustrates how the flash is avoided. BUG=681495 ========== to ========== Hack to force active stylesheet update for chrome://apps. *** NOT FOR LANDING *** This is not an acceptable solution, but illustrates how the flash is avoided. BUG=681495 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Hack to force active stylesheet update for chrome://apps. *** NOT FOR LANDING *** This is not an acceptable solution, but illustrates how the flash is avoided. BUG=681495 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Initially load new_tab.css with a timestamp for chrome://apps. This is what incognito_tab.html already does. Changing the url to add a timestamp query on DOMContentLoaded caused a FoUC. BUG=681495 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
rune@opera.com changed reviewers: + estade@chromium.org
The CQ bit was checked by rune@opera.com to run a CQ dry run
ptal
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2647653002/diff/20001/chrome/browser/resource... File chrome/browser/resources/ntp4/new_tab.html (left): https://codereview.chromium.org/2647653002/diff/20001/chrome/browser/resource... chrome/browser/resources/ntp4/new_tab.html:31: <link id="themecss" rel="stylesheet" href="chrome://theme/css/new_tab_theme.css"> maybe we could just use our new $i18n{} mechanism instead, i.e. <link id="themecss" rel="stylesheet" href="chrome://theme/css/new_tab_theme.css?$i18n{cacheBuster}"> and set a string in the C++ to a Date.now() equivalent (or anything that's fairly random, really) https://codereview.chromium.org/2647653002/diff/20001/chrome/browser/resource... File chrome/browser/resources/ntp4/new_tab.html (right): https://codereview.chromium.org/2647653002/diff/20001/chrome/browser/resource... chrome/browser/resources/ntp4/new_tab.html:35: </script> i thought CSP prevented inline scripts from running. are you sure this works?
estade@chromium.org changed reviewers: + dbeam@chromium.org
+dbeam, -estade
estade@chromium.org changed reviewers: - estade@chromium.org
https://codereview.chromium.org/2647653002/diff/20001/chrome/browser/resource... File chrome/browser/resources/ntp4/new_tab.html (left): https://codereview.chromium.org/2647653002/diff/20001/chrome/browser/resource... chrome/browser/resources/ntp4/new_tab.html:31: <link id="themecss" rel="stylesheet" href="chrome://theme/css/new_tab_theme.css"> On 2017/01/19 23:18:54, Dan Beam (slow - converging) wrote: > maybe we could just use our new $i18n{} mechanism instead, i.e. > > <link id="themecss" rel="stylesheet" > href="chrome://theme/css/new_tab_theme.css?$i18n{cacheBuster}"> > > and set a string in the C++ to a Date.now() equivalent (or anything that's > fairly random, really) Will that C++ string change on each load? I think it typically needs to. https://codereview.chromium.org/2647653002/diff/20001/chrome/browser/resource... File chrome/browser/resources/ntp4/new_tab.html (right): https://codereview.chromium.org/2647653002/diff/20001/chrome/browser/resource... chrome/browser/resources/ntp4/new_tab.html:35: </script> On 2017/01/19 23:18:54, Dan Beam (slow - converging) wrote: > i thought CSP prevented inline scripts from running. are you sure this works? Yes, it seems so. This is copied from incognito_tab.html, btw.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
i don't think this is like the awesomest way to do this, but it's simple and works https://codereview.chromium.org/2647653002/diff/20001/chrome/browser/resource... File chrome/browser/resources/ntp4/new_tab.html (right): https://codereview.chromium.org/2647653002/diff/20001/chrome/browser/resource... chrome/browser/resources/ntp4/new_tab.html:34: 'href="chrome://theme/css/new_tab_theme.css?' + Date.now() + '">'); 80 col wrap
lgtm
The CQ bit was checked by rune@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484983862114430,
"parent_rev": "b57345e696995369c8df3c23782734167386baee", "commit_rev":
"babe852aafe34f62d5ac8fbfc252830b64eebeea"}
Message was sent while issue was closed.
Description was changed from ========== Initially load new_tab.css with a timestamp for chrome://apps. This is what incognito_tab.html already does. Changing the url to add a timestamp query on DOMContentLoaded caused a FoUC. BUG=681495 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Initially load new_tab.css with a timestamp for chrome://apps. This is what incognito_tab.html already does. Changing the url to add a timestamp query on DOMContentLoaded caused a FoUC. BUG=681495 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2647653002 Cr-Commit-Position: refs/heads/master@{#445285} Committed: https://chromium.googlesource.com/chromium/src/+/babe852aafe34f62d5ac8fbfc252... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/babe852aafe34f62d5ac8fbfc252... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
