Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 2650573002: NetworkQualityEstimator: Update signal strength estimate periodically (Closed)

Created:
3 years, 11 months ago by tbansal1
Modified:
3 years, 11 months ago
Reviewers:
RyanSturm
CC:
chromium-reviews, cbentzel+watch_chromium.org, tbansal+watch-nqe_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NetworkQualityEstimator: Update signal strength estimate periodically Currently, the signal strength is updated when a main frame request is received. That approach does not work for net embedders that do not have a main frame concept (e.g., via cronet). This CL changes NQE to update the signal strength periodically without relying on the main frame requests. BUG=681929 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2650573002 Cr-Commit-Position: refs/heads/master@{#446329} Committed: https://chromium.googlesource.com/chromium/src/+/190e126297503e8c5da6bd72390af82dc757a897

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/nqe/network_quality_estimator.cc View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 28 (17 generated)
tbansal1
bengr: ptal. Thanks.
3 years, 11 months ago (2017-01-23 20:47:39 UTC) #8
tbansal1
ryansturm: ptal. Thanks.
3 years, 11 months ago (2017-01-25 18:03:18 UTC) #10
RyanSturm
Thanks for fixing this. lgtm
3 years, 11 months ago (2017-01-25 21:12:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650573002/1
3 years, 11 months ago (2017-01-25 21:14:01 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/220316)
3 years, 11 months ago (2017-01-26 00:23:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650573002/1
3 years, 11 months ago (2017-01-26 00:26:01 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/220578)
3 years, 11 months ago (2017-01-26 03:49:59 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650573002/1
3 years, 11 months ago (2017-01-26 04:21:11 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/220757)
3 years, 11 months ago (2017-01-26 07:25:22 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650573002/1
3 years, 11 months ago (2017-01-26 13:49:16 UTC) #25
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 15:07:44 UTC) #28
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/190e126297503e8c5da6bd72390a...

Powered by Google App Engine
This is Rietveld 408576698