|
|
Chromium Code Reviews
DescriptionNetworkQualityEstimator: Update signal strength estimate periodically
Currently, the signal strength is updated when a main frame request
is received. That approach does not work for net embedders that do
not have a main frame concept (e.g., via cronet). This CL changes NQE
to update the signal strength periodically without relying on the main frame requests.
BUG=681929
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
Review-Url: https://codereview.chromium.org/2650573002
Cr-Commit-Position: refs/heads/master@{#446329}
Committed: https://chromium.googlesource.com/chromium/src/+/190e126297503e8c5da6bd72390af82dc757a897
Patch Set 1 #
Messages
Total messages: 28 (17 generated)
Description was changed from ========== NQE signal; stremgth BUG= ========== to ========== NQE signal; strength BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== NQE signal; strength BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== NetworkQualityEstimator: Update signal strength estimate periodically Currently, the signal strength is updated when a main frame request is received. That approach does not work for net embedders that do not have a main frame concept (e.g., via cronet). This CL changes NQE to update the signal strength periodically without relying on the main frame requests. BUG=681929 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
tbansal@chromium.org changed reviewers: + bengr@chromium.org
bengr: ptal. Thanks.
tbansal@chromium.org changed reviewers: + ryansturm@chromium.org - bengr@chromium.org
ryansturm: ptal. Thanks.
Thanks for fixing this. lgtm
The CQ bit was checked by tbansal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by tbansal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by tbansal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by tbansal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485438540069940, "parent_rev":
"1498add8ed79bc971a9f786662de9716270fad7c", "commit_rev":
"190e126297503e8c5da6bd72390af82dc757a897"}
Message was sent while issue was closed.
Description was changed from ========== NetworkQualityEstimator: Update signal strength estimate periodically Currently, the signal strength is updated when a main frame request is received. That approach does not work for net embedders that do not have a main frame concept (e.g., via cronet). This CL changes NQE to update the signal strength periodically without relying on the main frame requests. BUG=681929 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== NetworkQualityEstimator: Update signal strength estimate periodically Currently, the signal strength is updated when a main frame request is received. That approach does not work for net embedders that do not have a main frame concept (e.g., via cronet). This CL changes NQE to update the signal strength periodically without relying on the main frame requests. BUG=681929 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2650573002 Cr-Commit-Position: refs/heads/master@{#446329} Committed: https://chromium.googlesource.com/chromium/src/+/190e126297503e8c5da6bd72390a... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/190e126297503e8c5da6bd72390a... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
