Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Unified Diff: net/nqe/network_quality_estimator.cc

Issue 2650573002: NetworkQualityEstimator: Update signal strength estimate periodically (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/network_quality_estimator.cc
diff --git a/net/nqe/network_quality_estimator.cc b/net/nqe/network_quality_estimator.cc
index 4950bef439455a9290f23e0bc4498969909ec820..73118fc57b62fc3c33abf34011c6bf2dae8bd32b 100644
--- a/net/nqe/network_quality_estimator.cc
+++ b/net/nqe/network_quality_estimator.cc
@@ -442,7 +442,6 @@ void NetworkQualityEstimator::NotifyHeadersReceived(const URLRequest& request) {
weak_ptr_factory_.GetWeakPtr(), measuring_delay),
measuring_delay);
}
- UpdateSignalStrength();
}
LoadTimingInfo load_timing_info;
@@ -838,7 +837,6 @@ void NetworkQualityEstimator::OnConnectionTypeChanged(
estimated_quality_at_last_main_frame_ = nqe::internal::NetworkQuality();
throughput_analyzer_->OnConnectionTypeChanged();
MaybeComputeEffectiveConnectionType();
- UpdateSignalStrength();
}
void NetworkQualityEstimator::MaybeQueryExternalEstimateProvider() const {
@@ -1020,6 +1018,8 @@ void NetworkQualityEstimator::RecordMetricsOnMainFrameRequest() const {
void NetworkQualityEstimator::ComputeEffectiveConnectionType() {
DCHECK(thread_checker_.CalledOnValidThread());
+ UpdateSignalStrength();
+
const base::TimeTicks now = tick_clock_->NowTicks();
const EffectiveConnectionType past_type = effective_connection_type_;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698