Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 2650423002: [ObjC ARC] Converts ios/chrome/browser/ui/history:unit_tests to ARC. (Closed)

Created:
3 years, 11 months ago by stkhapugin
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/history:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2650423002 Cr-Commit-Position: refs/heads/master@{#476653} Committed: https://chromium.googlesource.com/chromium/src/+/198dcbc93706388bf415866519065dc316f261be

Patch Set 1 #

Total comments: 9

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -79 lines) Patch
M ios/chrome/browser/ui/history/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm View 1 4 chunks +14 lines, -11 lines 0 comments Download
M ios/chrome/browser/ui/history/history_entries_status_item_unittest.mm View 5 chunks +13 lines, -13 lines 0 comments Download
M ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm View 1 6 chunks +19 lines, -16 lines 0 comments Download
M ios/chrome/browser/ui/history/history_entry_item_unittest.mm View 4 chunks +12 lines, -11 lines 0 comments Download
M ios/chrome/browser/ui/history/history_search_view_controller_unittest.mm View 1 4 chunks +22 lines, -21 lines 0 comments Download
M ios/chrome/browser/ui/history/history_util_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/history/tab_history_popup_controller_unittest.mm View 1 4 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 32 (19 generated)
stkhapugin
ptal
3 years, 10 months ago (2017-01-27 15:45:56 UTC) #6
noyau (Ping after 24h)
https://codereview.chromium.org/2650423002/diff/1/ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm File ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm (right): https://codereview.chromium.org/2650423002/diff/1/ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm#newcode144 ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm:144: __unsafe_unretained FaviconViewProvider* viewProvider; Needs a comment. https://codereview.chromium.org/2650423002/diff/1/ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm File ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm ...
3 years, 10 months ago (2017-01-27 16:04:39 UTC) #7
sczs
lgtm https://codereview.chromium.org/2650423002/diff/1/ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm File ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm (right): https://codereview.chromium.org/2650423002/diff/1/ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm#newcode167 ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm:167: __unsafe_unretained FaviconViewProvider* viewProvider; There's probably a good reason, ...
3 years, 10 months ago (2017-01-27 18:55:40 UTC) #8
stkhapugin
https://codereview.chromium.org/2650423002/diff/1/ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm File ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm (right): https://codereview.chromium.org/2650423002/diff/1/ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm#newcode144 ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm:144: __unsafe_unretained FaviconViewProvider* viewProvider; On 2017/01/27 16:04:38, noyau wrote: > ...
3 years, 10 months ago (2017-02-02 15:29:23 UTC) #9
noyau (Ping after 24h)
https://codereview.chromium.org/2650423002/diff/1/ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm File ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm (right): https://codereview.chromium.org/2650423002/diff/1/ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm#newcode48 ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm:48: CollectionViewModel* model_; On 2017/02/02 15:29:23, stkhapugin wrote: > On ...
3 years, 10 months ago (2017-02-03 12:16:46 UTC) #10
stkhapugin
https://codereview.chromium.org/2650423002/diff/1/ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm File ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm (right): https://codereview.chromium.org/2650423002/diff/1/ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm#newcode48 ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm:48: CollectionViewModel* model_; On 2017/02/03 12:16:46, noyau wrote: > On ...
3 years, 10 months ago (2017-02-03 13:11:37 UTC) #11
noyau (Ping after 24h)
On 2017/02/03 13:11:37, stkhapugin wrote: > https://codereview.chromium.org/2650423002/diff/1/ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm > File ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm (right): > > https://codereview.chromium.org/2650423002/diff/1/ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm#newcode48 > ...
3 years, 7 months ago (2017-05-09 13:28:36 UTC) #16
stkhapugin
Finally got to this. noyau, ptal! https://codereview.chromium.org/2650423002/diff/1/ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm File ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm (right): https://codereview.chromium.org/2650423002/diff/1/ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm#newcode48 ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm:48: CollectionViewModel* model_; On ...
3 years, 6 months ago (2017-05-30 18:19:00 UTC) #17
noyau (Ping after 24h)
lgtm
3 years, 6 months ago (2017-06-02 09:16:39 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650423002/20001
3 years, 6 months ago (2017-06-02 09:16:50 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/309098)
3 years, 6 months ago (2017-06-02 11:17:39 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650423002/20001
3 years, 6 months ago (2017-06-02 12:44:49 UTC) #29
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 15:08:01 UTC) #32
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/198dcbc93706388bf41586651906...

Powered by Google App Engine
This is Rietveld 408576698