| OLD | NEW |
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #import "ios/chrome/browser/ui/history/favicon_view_provider.h" | 5 #import "ios/chrome/browser/ui/history/favicon_view_provider.h" |
| 6 | 6 |
| 7 #include <memory> | 7 #include <memory> |
| 8 | 8 |
| 9 #include "base/files/file_path.h" | 9 #include "base/files/file_path.h" |
| 10 #include "base/files/file_util.h" | 10 #include "base/files/file_util.h" |
| 11 #include "base/location.h" | 11 #include "base/location.h" |
| 12 #include "base/mac/scoped_nsobject.h" | |
| 13 #include "base/path_service.h" | 12 #include "base/path_service.h" |
| 14 #include "base/single_thread_task_runner.h" | 13 #include "base/single_thread_task_runner.h" |
| 15 #include "base/strings/sys_string_conversions.h" | 14 #include "base/strings/sys_string_conversions.h" |
| 16 #include "base/threading/thread_task_runner_handle.h" | 15 #include "base/threading/thread_task_runner_handle.h" |
| 17 #include "components/favicon/core/large_icon_service.h" | 16 #include "components/favicon/core/large_icon_service.h" |
| 18 #include "components/favicon/core/test/mock_favicon_service.h" | 17 #include "components/favicon/core/test/mock_favicon_service.h" |
| 19 #include "components/favicon_base/fallback_icon_style.h" | 18 #include "components/favicon_base/fallback_icon_style.h" |
| 20 #include "components/favicon_base/favicon_types.h" | 19 #include "components/favicon_base/favicon_types.h" |
| 21 #include "ios/chrome/browser/chrome_paths.h" | 20 #include "ios/chrome/browser/chrome_paths.h" |
| 22 #include "ios/web/public/test/test_web_thread.h" | 21 #include "ios/web/public/test/test_web_thread.h" |
| 23 #include "ios/web/public/test/test_web_thread_bundle.h" | 22 #include "ios/web/public/test/test_web_thread_bundle.h" |
| 24 #include "skia/ext/skia_utils_ios.h" | 23 #include "skia/ext/skia_utils_ios.h" |
| 25 #include "testing/gmock/include/gmock/gmock.h" | 24 #include "testing/gmock/include/gmock/gmock.h" |
| 26 #include "testing/gtest_mac.h" | 25 #include "testing/gtest_mac.h" |
| 27 #include "testing/platform_test.h" | 26 #include "testing/platform_test.h" |
| 28 #include "third_party/ocmock/OCMock/OCMock.h" | 27 #include "third_party/ocmock/OCMock/OCMock.h" |
| 29 #include "third_party/ocmock/gtest_support.h" | 28 #include "third_party/ocmock/gtest_support.h" |
| 30 #include "third_party/skia/include/core/SkColor.h" | 29 #include "third_party/skia/include/core/SkColor.h" |
| 31 #include "url/gurl.h" | 30 #include "url/gurl.h" |
| 32 | 31 |
| 32 #if !defined(__has_feature) || !__has_feature(objc_arc) |
| 33 #error "This file requires ARC support." |
| 34 #endif |
| 35 |
| 33 @interface FaviconViewProvider (Testing) | 36 @interface FaviconViewProvider (Testing) |
| 34 @property(nonatomic, retain) UIImage* favicon; | 37 @property(nonatomic, retain) UIImage* favicon; |
| 35 @property(nonatomic, copy) NSString* fallbackText; | 38 @property(nonatomic, copy) NSString* fallbackText; |
| 36 @property(nonatomic, retain) UIColor* fallbackBackgroundColor; | 39 @property(nonatomic, retain) UIColor* fallbackBackgroundColor; |
| 37 @property(nonatomic, retain) UIColor* fallbackTextColor; | 40 @property(nonatomic, retain) UIColor* fallbackTextColor; |
| 38 @end | 41 @end |
| 39 | 42 |
| 40 namespace { | 43 namespace { |
| 41 | 44 |
| 42 using favicon::PostReply; | 45 using favicon::PostReply; |
| (...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 91 web::TestWebThreadBundle thread_bundle_; | 94 web::TestWebThreadBundle thread_bundle_; |
| 92 testing::StrictMock<favicon::MockFaviconService> mock_favicon_service_; | 95 testing::StrictMock<favicon::MockFaviconService> mock_favicon_service_; |
| 93 std::unique_ptr<favicon::LargeIconService> large_icon_service_; | 96 std::unique_ptr<favicon::LargeIconService> large_icon_service_; |
| 94 base::CancelableTaskTracker cancelable_task_tracker_; | 97 base::CancelableTaskTracker cancelable_task_tracker_; |
| 95 }; | 98 }; |
| 96 | 99 |
| 97 // Tests that image is set when a favicon is returned from LargeIconService. | 100 // Tests that image is set when a favicon is returned from LargeIconService. |
| 98 TEST_F(FaviconViewProviderTest, Favicon) { | 101 TEST_F(FaviconViewProviderTest, Favicon) { |
| 99 id mock_delegate = | 102 id mock_delegate = |
| 100 [OCMockObject mockForProtocol:@protocol(FaviconViewProviderDelegate)]; | 103 [OCMockObject mockForProtocol:@protocol(FaviconViewProviderDelegate)]; |
| 101 base::scoped_nsobject<FaviconViewProvider> viewProvider( | 104 FaviconViewProvider* viewProvider = |
| 102 [[FaviconViewProvider alloc] initWithURL:GURL(kTestFaviconURL) | 105 [[FaviconViewProvider alloc] initWithURL:GURL(kTestFaviconURL) |
| 103 faviconSize:kTestFaviconSize | 106 faviconSize:kTestFaviconSize |
| 104 minFaviconSize:kTestFaviconSize | 107 minFaviconSize:kTestFaviconSize |
| 105 largeIconService:large_icon_service_.get() | 108 largeIconService:large_icon_service_.get() |
| 106 delegate:mock_delegate]); | 109 delegate:mock_delegate]; |
| 107 void (^confirmationBlock)(NSInvocation*) = ^(NSInvocation* invocation) { | 110 void (^confirmationBlock)(NSInvocation*) = ^(NSInvocation* invocation) { |
| 108 FaviconViewProvider* viewProvider; | 111 __unsafe_unretained FaviconViewProvider* viewProvider; |
| 109 [invocation getArgument:&viewProvider atIndex:2]; | 112 [invocation getArgument:&viewProvider atIndex:2]; |
| 110 EXPECT_NSNE(nil, viewProvider.favicon); | 113 EXPECT_NSNE(nil, viewProvider.favicon); |
| 111 }; | 114 }; |
| 112 [[[mock_delegate stub] andDo:confirmationBlock] | 115 [[[mock_delegate stub] andDo:confirmationBlock] |
| 113 faviconViewProviderFaviconDidLoad:viewProvider]; | 116 faviconViewProviderFaviconDidLoad:viewProvider]; |
| 114 EXPECT_OCMOCK_VERIFY(mock_delegate); | 117 EXPECT_OCMOCK_VERIFY(mock_delegate); |
| 115 } | 118 } |
| 116 | 119 |
| 117 // Tests that fallback data is set when no favicon is returned from | 120 // Tests that fallback data is set when no favicon is returned from |
| 118 // LargeIconService. | 121 // LargeIconService. |
| 119 TEST_F(FaviconViewProviderTest, FallbackIcon) { | 122 TEST_F(FaviconViewProviderTest, FallbackIcon) { |
| 120 EXPECT_CALL(mock_favicon_service_, GetLargestRawFaviconForPageURL( | 123 EXPECT_CALL(mock_favicon_service_, GetLargestRawFaviconForPageURL( |
| 121 GURL(kTestFallbackURL), _, _, _, _)) | 124 GURL(kTestFallbackURL), _, _, _, _)) |
| 122 .WillRepeatedly(PostReply<5>(favicon_base::FaviconRawBitmapResult())); | 125 .WillRepeatedly(PostReply<5>(favicon_base::FaviconRawBitmapResult())); |
| 123 | 126 |
| 124 id mock_delegate = | 127 id mock_delegate = |
| 125 [OCMockObject mockForProtocol:@protocol(FaviconViewProviderDelegate)]; | 128 [OCMockObject mockForProtocol:@protocol(FaviconViewProviderDelegate)]; |
| 126 base::scoped_nsobject<FaviconViewProvider> item([[FaviconViewProvider alloc] | 129 FaviconViewProvider* item = |
| 127 initWithURL:GURL(kTestFallbackURL) | 130 [[FaviconViewProvider alloc] initWithURL:GURL(kTestFallbackURL) |
| 128 faviconSize:kTestFaviconSize | 131 faviconSize:kTestFaviconSize |
| 129 minFaviconSize:kTestFaviconSize | 132 minFaviconSize:kTestFaviconSize |
| 130 largeIconService:large_icon_service_.get() | 133 largeIconService:large_icon_service_.get() |
| 131 delegate:mock_delegate]); | 134 delegate:mock_delegate]; |
| 132 | 135 |
| 133 // Confirm that fallback text and color have been set before delegate call. | 136 // Confirm that fallback text and color have been set before delegate call. |
| 134 void (^confirmationBlock)(NSInvocation*) = ^(NSInvocation* invocation) { | 137 void (^confirmationBlock)(NSInvocation*) = ^(NSInvocation* invocation) { |
| 135 FaviconViewProvider* viewProvider; | 138 __unsafe_unretained FaviconViewProvider* viewProvider; |
| 136 [invocation getArgument:&viewProvider atIndex:2]; | 139 [invocation getArgument:&viewProvider atIndex:2]; |
| 137 // Fallback text is the first letter of the URL. | 140 // Fallback text is the first letter of the URL. |
| 138 NSString* defaultText = @"T"; | 141 NSString* defaultText = @"T"; |
| 139 // Default colors are defined in | 142 // Default colors are defined in |
| 140 // components/favicon_base/fallback_icon_style.h. | 143 // components/favicon_base/fallback_icon_style.h. |
| 141 UIColor* defaultTextColor = skia::UIColorFromSkColor(SK_ColorWHITE); | 144 UIColor* defaultTextColor = skia::UIColorFromSkColor(SK_ColorWHITE); |
| 142 UIColor* defaultBackgroundColor = | 145 UIColor* defaultBackgroundColor = |
| 143 skia::UIColorFromSkColor(SkColorSetRGB(0x78, 0x78, 0x78)); | 146 skia::UIColorFromSkColor(SkColorSetRGB(0x78, 0x78, 0x78)); |
| 144 EXPECT_NSEQ(defaultText, viewProvider.fallbackText); | 147 EXPECT_NSEQ(defaultText, viewProvider.fallbackText); |
| 145 EXPECT_NSEQ(defaultTextColor, viewProvider.fallbackTextColor); | 148 EXPECT_NSEQ(defaultTextColor, viewProvider.fallbackTextColor); |
| 146 EXPECT_NSEQ(defaultBackgroundColor, viewProvider.fallbackBackgroundColor); | 149 EXPECT_NSEQ(defaultBackgroundColor, viewProvider.fallbackBackgroundColor); |
| 147 }; | 150 }; |
| 148 [[[mock_delegate stub] andDo:confirmationBlock] | 151 [[[mock_delegate stub] andDo:confirmationBlock] |
| 149 faviconViewProviderFaviconDidLoad:item]; | 152 faviconViewProviderFaviconDidLoad:item]; |
| 150 EXPECT_OCMOCK_VERIFY(mock_delegate); | 153 EXPECT_OCMOCK_VERIFY(mock_delegate); |
| 151 } | 154 } |
| 152 | 155 |
| 153 } // namespace | 156 } // namespace |
| OLD | NEW |