Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2650403002: Revert of Add null check to animations for registered custom property initial values (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add null check to animations for registered custom property initial values (patchset #2 id:20001 of https://codereview.chromium.org/2649863006/ ) Reason for revert: This goes together with the revert https://codereview.chromium.org/2649103008/ ; looks like the two CLs didn't match up, https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/29275 (Hope the double revert doesn't cause too much work.) Original issue's description: > Add null check to animations for registered custom property initial values > > After a recent change to CSSInterpolationType for registered custom properties > it was assumed that all registered custom properties had initial CSSValues. > This is not the case and null derefs were reachable. This patch fixes up > the false assumption. > > BUG=684234 > > Review-Url: https://codereview.chromium.org/2649863006 > Cr-Commit-Position: refs/heads/master@{#445969} > Committed: https://chromium.googlesource.com/chromium/src/+/f2ec8922cbe5f632a937cf242faf5f23c0d1b3ff TBR=ericwilligers@chromium.org,alancutter@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=684234 Review-Url: https://codereview.chromium.org/2650403002 Cr-Commit-Position: refs/heads/master@{#445996} Committed: https://chromium.googlesource.com/chromium/src/+/af23a0c634f77c940bc54aea0c92880c1f3c4e6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -56 lines) Patch
D third_party/WebKit/LayoutTests/animations/custom-properties/empty-initial-value-crash.html View 1 chunk +0 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp View 3 chunks +13 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sof
Created Revert of Add null check to animations for registered custom property initial values
3 years, 11 months ago (2017-01-25 11:11:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650403002/1
3 years, 11 months ago (2017-01-25 11:12:10 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 11:13:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/af23a0c634f77c940bc54aea0c92...

Powered by Google App Engine
This is Rietveld 408576698