Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2649863006: Add null check to animations for registered custom property initial values (Closed)

Created:
3 years, 11 months ago by alancutter (OOO until 2018)
Modified:
3 years, 10 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add null check to animations for registered custom property initial values After a recent change to CSSInterpolationType for registered custom properties it was assumed that all registered custom properties had initial CSSValues. This is not the case and null derefs were reachable. This patch fixes up the false assumption. BUG=684234, 685472 Review-Url: https://codereview.chromium.org/2649863006 Cr-Original-Commit-Position: refs/heads/master@{#445969} Committed: https://chromium.googlesource.com/chromium/src/+/f2ec8922cbe5f632a937cf242faf5f23c0d1b3ff Review-Url: https://codereview.chromium.org/2649863006 Cr-Commit-Position: refs/heads/master@{#447095} Committed: https://chromium.googlesource.com/chromium/src/+/1f1de2e98a13bae871ef18de230ec8ff45965eaf

Patch Set 1 #

Patch Set 2 : moarTest #

Patch Set 3 : Fix shadowed variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -11 lines) Patch
A third_party/WebKit/LayoutTests/animations/custom-properties/empty-initial-value-crash.html View 1 1 chunk +31 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp View 1 2 3 chunks +23 lines, -11 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
alancutter (OOO until 2018)
3 years, 11 months ago (2017-01-24 02:38:31 UTC) #3
Eric Willigers
lgtm
3 years, 11 months ago (2017-01-25 04:04:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649863006/20001
3 years, 11 months ago (2017-01-25 04:32:19 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f2ec8922cbe5f632a937cf242faf5f23c0d1b3ff
3 years, 11 months ago (2017-01-25 06:22:59 UTC) #9
sof
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2650403002/ by sigbjornf@opera.com. ...
3 years, 11 months ago (2017-01-25 11:11:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649863006/40001
3 years, 10 months ago (2017-01-30 20:57:50 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 22:48:10 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1f1de2e98a13bae871ef18de230e...

Powered by Google App Engine
This is Rietveld 408576698