Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2650383007: Move Task Scheduler Single Thread Task Runners to Dedicated Threads (Closed)

Created:
3 years, 11 months ago by robliao
Modified:
3 years, 10 months ago
Reviewers:
gab, fdoray
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Task Scheduler Single Thread Task Runners to Dedicated Threads This quick patch reuses existing machinery to have one TaskScheduler backed SingleThreadTaskRunner mapped to a single dedicated thread. BUG=684080

Patch Set 1 #

Total comments: 42

Patch Set 2 : CR Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+630 lines, -40 lines) Patch
M base/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A base/task_scheduler/scheduler_single_thread_worker_pool_manager.h View 1 1 chunk +77 lines, -0 lines 0 comments Download
A base/task_scheduler/scheduler_single_thread_worker_pool_manager.cc View 1 1 chunk +223 lines, -0 lines 0 comments Download
A base/task_scheduler/scheduler_single_thread_worker_pool_manager_unittest.cc View 1 chunk +178 lines, -0 lines 0 comments Download
M base/task_scheduler/scheduler_worker_pool_impl.h View 1 4 chunks +26 lines, -1 line 0 comments Download
M base/task_scheduler/scheduler_worker_pool_impl.cc View 1 9 chunks +67 lines, -19 lines 0 comments Download
M base/task_scheduler/scheduler_worker_pool_impl_unittest.cc View 1 9 chunks +39 lines, -11 lines 0 comments Download
M base/task_scheduler/scheduler_worker_pool_params.h View 1 3 chunks +2 lines, -5 lines 0 comments Download
M base/task_scheduler/scheduler_worker_pool_params.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl.cc View 4 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (21 generated)
robliao
Here's the idea we discussed for single threaded task runners with adjustments as I ran ...
3 years, 11 months ago (2017-01-27 01:57:32 UTC) #4
fdoray
https://codereview.chromium.org/2650383007/diff/60001/base/task_scheduler/scheduler_single_thread_worker_pool_manager.cc File base/task_scheduler/scheduler_single_thread_worker_pool_manager.cc (right): https://codereview.chromium.org/2650383007/diff/60001/base/task_scheduler/scheduler_single_thread_worker_pool_manager.cc#newcode42 base/task_scheduler/scheduler_single_thread_worker_pool_manager.cc:42: void JoinForTesting() { Set a |join_for_testing_called_| flag and DCHECK ...
3 years, 10 months ago (2017-01-27 16:47:35 UTC) #20
robliao
Thanks for the comments! https://codereview.chromium.org/2650383007/diff/60001/base/task_scheduler/scheduler_single_thread_worker_pool_manager.cc File base/task_scheduler/scheduler_single_thread_worker_pool_manager.cc (right): https://codereview.chromium.org/2650383007/diff/60001/base/task_scheduler/scheduler_single_thread_worker_pool_manager.cc#newcode42 base/task_scheduler/scheduler_single_thread_worker_pool_manager.cc:42: void JoinForTesting() { On 2017/01/27 ...
3 years, 10 months ago (2017-01-27 21:25:41 UTC) #23
robliao
3 years, 10 months ago (2017-02-01 23:57:58 UTC) #25
Message was sent while issue was closed.
Closing for now. We're going to go ahead and table the LA design and do this the
right way.

Powered by Google App Engine
This is Rietveld 408576698