Move Task Scheduler Single Thread Task Runners to Dedicated Threads

base/task_scheduler/scheduler_worker_pool_params.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_TASK_SCHEDULER_SCHEDULER_WORKER_POOL_PARAMS_H_
 #define BASE_TASK_SCHEDULER_SCHEDULER_WORKER_POOL_PARAMS_H_
 
 #include <string>
 
 #include "base/macros.h"

[fdoray, 2017/01/27 16:47:35]

 Not needed anymore.

[robliao, 2017/01/27 21:25:41]

Done.

 #include "base/task_scheduler/scheduler_worker_params.h"
 #include "base/threading/platform_thread.h"
 #include "base/time/time.h"
 
 namespace base {
 
 class BASE_EXPORT SchedulerWorkerPoolParams final {
  public:
   enum class StandbyThreadPolicy {
     // Create threads as needed on demand, reclaimed as necessary.
@@ skipping 14 matching lines @@
   // value for performance or correctness reasons. |backward_compatibility|
   // indicates whether backward compatibility is enabled.
   SchedulerWorkerPoolParams(
       const std::string& name,
       ThreadPriority priority_hint,
       StandbyThreadPolicy standby_thread_policy,
       int max_threads,
       TimeDelta suggested_reclaim_time,
       SchedulerBackwardCompatibility backward_compatibility =
           SchedulerBackwardCompatibility::DISABLED);
+  SchedulerWorkerPoolParams(const SchedulerWorkerPoolParams& other);
+  SchedulerWorkerPoolParams& operator=(const SchedulerWorkerPoolParams& other);
   SchedulerWorkerPoolParams(SchedulerWorkerPoolParams&& other);

[fdoray, 2017/01/27 16:47:35]

You can remove lines 47-48. These methods pretend to be a move constructor / a
move assign operator but they just copy all members...

[robliao, 2017/01/27 21:25:41]

Done.

   SchedulerWorkerPoolParams& operator=(SchedulerWorkerPoolParams&& other);
 
   const std::string& name() const { return name_; }
   ThreadPriority priority_hint() const { return priority_hint_; }
   StandbyThreadPolicy standby_thread_policy() const {
     return standby_thread_policy_;
   }
   size_t max_threads() const { return max_threads_; }
   TimeDelta suggested_reclaim_time() const { return suggested_reclaim_time_; }
   SchedulerBackwardCompatibility backward_compatibility() const {
     return backward_compatibility_;
   }
 
  private:
   std::string name_;
   ThreadPriority priority_hint_;
   StandbyThreadPolicy standby_thread_policy_;
   size_t max_threads_;
   TimeDelta suggested_reclaim_time_;
   SchedulerBackwardCompatibility backward_compatibility_;
-
-  DISALLOW_COPY_AND_ASSIGN(SchedulerWorkerPoolParams);
 };
 
 }  // namespace base
 
 #endif  // BASE_TASK_SCHEDULER_SCHEDULER_WORKER_POOL_PARAMS_H_