Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: base/task_scheduler/task_scheduler_impl.cc

Issue 2650383007: Move Task Scheduler Single Thread Task Runners to Dedicated Threads (Closed)
Patch Set: CR Feedback Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/task_scheduler/task_scheduler_impl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/task_scheduler/task_scheduler_impl.h" 5 #include "base/task_scheduler/task_scheduler_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "base/memory/ptr_util.h" 11 #include "base/memory/ptr_util.h"
12 #include "base/task_scheduler/delayed_task_manager.h" 12 #include "base/task_scheduler/delayed_task_manager.h"
13 #include "base/task_scheduler/scheduler_single_thread_worker_pool_manager.h"
13 #include "base/task_scheduler/scheduler_worker_pool_params.h" 14 #include "base/task_scheduler/scheduler_worker_pool_params.h"
14 #include "base/task_scheduler/sequence_sort_key.h" 15 #include "base/task_scheduler/sequence_sort_key.h"
15 #include "base/task_scheduler/task.h" 16 #include "base/task_scheduler/task.h"
16 #include "base/task_scheduler/task_tracker.h" 17 #include "base/task_scheduler/task_tracker.h"
17 #include "build/build_config.h" 18 #include "build/build_config.h"
18 19
19 #if defined(OS_POSIX) && !defined(OS_NACL_SFI) 20 #if defined(OS_POSIX) && !defined(OS_NACL_SFI)
20 #include "base/task_scheduler/task_tracker_posix.h" 21 #include "base/task_scheduler/task_tracker_posix.h"
21 #endif 22 #endif
22 23
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 scoped_refptr<SequencedTaskRunner> 60 scoped_refptr<SequencedTaskRunner>
60 TaskSchedulerImpl::CreateSequencedTaskRunnerWithTraits( 61 TaskSchedulerImpl::CreateSequencedTaskRunnerWithTraits(
61 const TaskTraits& traits) { 62 const TaskTraits& traits) {
62 return GetWorkerPoolForTraits(traits)->CreateSequencedTaskRunnerWithTraits( 63 return GetWorkerPoolForTraits(traits)->CreateSequencedTaskRunnerWithTraits(
63 traits); 64 traits);
64 } 65 }
65 66
66 scoped_refptr<SingleThreadTaskRunner> 67 scoped_refptr<SingleThreadTaskRunner>
67 TaskSchedulerImpl::CreateSingleThreadTaskRunnerWithTraits( 68 TaskSchedulerImpl::CreateSingleThreadTaskRunnerWithTraits(
68 const TaskTraits& traits) { 69 const TaskTraits& traits) {
69 return GetWorkerPoolForTraits(traits)->CreateSingleThreadTaskRunnerWithTraits( 70 return scheduler_single_thread_worker_pool_manager_
70 traits); 71 ->CreateSingleThreadTaskRunnerWithTraits(traits);
71 } 72 }
72 73
73 std::vector<const HistogramBase*> TaskSchedulerImpl::GetHistograms() const { 74 std::vector<const HistogramBase*> TaskSchedulerImpl::GetHistograms() const {
74 std::vector<const HistogramBase*> histograms; 75 std::vector<const HistogramBase*> histograms;
75 for (const auto& worker_pool : worker_pools_) 76 for (const auto& worker_pool : worker_pools_)
76 worker_pool->GetHistograms(&histograms); 77 worker_pool->GetHistograms(&histograms);
77 78
78 return histograms; 79 return histograms;
79 } 80 }
80 81
81 void TaskSchedulerImpl::Shutdown() { 82 void TaskSchedulerImpl::Shutdown() {
82 // TODO(fdoray): Increase the priority of BACKGROUND tasks blocking shutdown. 83 // TODO(fdoray): Increase the priority of BACKGROUND tasks blocking shutdown.
83 DCHECK(task_tracker_); 84 DCHECK(task_tracker_);
84 task_tracker_->Shutdown(); 85 task_tracker_->Shutdown();
85 } 86 }
86 87
87 void TaskSchedulerImpl::FlushForTesting() { 88 void TaskSchedulerImpl::FlushForTesting() {
88 DCHECK(task_tracker_); 89 DCHECK(task_tracker_);
89 task_tracker_->Flush(); 90 task_tracker_->Flush();
90 } 91 }
91 92
92 void TaskSchedulerImpl::JoinForTesting() { 93 void TaskSchedulerImpl::JoinForTesting() {
93 #if DCHECK_IS_ON() 94 #if DCHECK_IS_ON()
94 DCHECK(!join_for_testing_returned_.IsSet()); 95 DCHECK(!join_for_testing_returned_.IsSet());
95 #endif 96 #endif
96 for (const auto& worker_pool : worker_pools_) 97 for (const auto& worker_pool : worker_pools_)
97 worker_pool->DisallowWorkerDetachmentForTesting(); 98 worker_pool->DisallowWorkerDetachmentForTesting();
98 for (const auto& worker_pool : worker_pools_) 99 for (const auto& worker_pool : worker_pools_)
99 worker_pool->JoinForTesting(); 100 worker_pool->JoinForTesting();
101 scheduler_single_thread_worker_pool_manager_->JoinForTesting();
100 service_thread_.Stop(); 102 service_thread_.Stop();
101 #if DCHECK_IS_ON() 103 #if DCHECK_IS_ON()
102 join_for_testing_returned_.Set(); 104 join_for_testing_returned_.Set();
103 #endif 105 #endif
104 } 106 }
105 107
106 TaskSchedulerImpl::TaskSchedulerImpl(const WorkerPoolIndexForTraitsCallback& 108 TaskSchedulerImpl::TaskSchedulerImpl(const WorkerPoolIndexForTraitsCallback&
107 worker_pool_index_for_traits_callback) 109 worker_pool_index_for_traits_callback)
108 : service_thread_("TaskSchedulerServiceThread"), 110 : service_thread_("TaskSchedulerServiceThread"),
109 worker_pool_index_for_traits_callback_( 111 worker_pool_index_for_traits_callback_(
(...skipping 26 matching lines...) Expand all
136 static_cast<MessageLoopForIO*>(service_thread_.message_loop())); 138 static_cast<MessageLoopForIO*>(service_thread_.message_loop()));
137 #else 139 #else
138 base::MakeUnique<TaskTracker>(); 140 base::MakeUnique<TaskTracker>();
139 #endif 141 #endif
140 142
141 // Instantiate DelayedTaskManager. Needs to happen after starting the service 143 // Instantiate DelayedTaskManager. Needs to happen after starting the service
142 // thread to get its task_runner(). 144 // thread to get its task_runner().
143 delayed_task_manager_ = 145 delayed_task_manager_ =
144 base::MakeUnique<DelayedTaskManager>(service_thread_.task_runner()); 146 base::MakeUnique<DelayedTaskManager>(service_thread_.task_runner());
145 147
148 scheduler_single_thread_worker_pool_manager_ =
149 base::MakeUnique<SchedulerSingleThreadWorkerPoolManager>(
150 worker_pool_params_vector, worker_pool_index_for_traits_callback_,
151 task_tracker_.get(), delayed_task_manager_.get());
152
146 // Callback invoked by workers to re-enqueue a sequence in the appropriate 153 // Callback invoked by workers to re-enqueue a sequence in the appropriate
147 // PriorityQueue. 154 // PriorityQueue.
148 const SchedulerWorkerPoolImpl::ReEnqueueSequenceCallback 155 const SchedulerWorkerPoolImpl::ReEnqueueSequenceCallback
149 re_enqueue_sequence_callback = 156 re_enqueue_sequence_callback =
150 Bind(&TaskSchedulerImpl::ReEnqueueSequenceCallback, Unretained(this)); 157 Bind(&TaskSchedulerImpl::ReEnqueueSequenceCallback, Unretained(this));
151 158
152 // Start worker pools. 159 // Start worker pools.
153 for (const auto& worker_pool_params : worker_pool_params_vector) { 160 for (const auto& worker_pool_params : worker_pool_params_vector) {
154 // Passing pointers to objects owned by |this| to 161 // Passing pointers to objects owned by |this| to
155 // SchedulerWorkerPoolImpl::Create() is safe because a TaskSchedulerImpl 162 // SchedulerWorkerPoolImpl::Create() is safe because a TaskSchedulerImpl
(...skipping 23 matching lines...) Expand all
179 // in |sequence|. 186 // in |sequence|.
180 const TaskTraits traits = 187 const TaskTraits traits =
181 sequence->PeekTaskTraits().WithPriority(sort_key.priority()); 188 sequence->PeekTaskTraits().WithPriority(sort_key.priority());
182 189
183 GetWorkerPoolForTraits(traits)->ReEnqueueSequence(std::move(sequence), 190 GetWorkerPoolForTraits(traits)->ReEnqueueSequence(std::move(sequence),
184 sort_key); 191 sort_key);
185 } 192 }
186 193
187 } // namespace internal 194 } // namespace internal
188 } // namespace base 195 } // namespace base
OLDNEW
« no previous file with comments | « base/task_scheduler/task_scheduler_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698