MD Downloads: convert <paper-dropdown-menu> to <dialog is="cr-action-menu">

MD Downloads: convert <paper-dropdown-menu> to <dialog is="cr-action-menu">

Looks and acts better; chops 66,664 bytes off vulcanized/crisper (pre-gzip).

R=dpapad@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2650303003
Cr-Commit-Position: refs/heads/master@{#445926}
Committed: https://chromium.googlesource.com/chromium/src/+/ad74cd3f5bb1ba01c0767a21edbb88057d4c20e9

[Dan Beam, 2017-01-25 00:16:52]

Description was changed from

==========
MD Downloads: convert <paper-dropdown-menu> to <dialog is="cr-action-menu">

R=dpapad@chromium.org
BUG=none
==========

to

==========
MD Downloads: convert <paper-dropdown-menu> to <dialog is="cr-action-menu">

R=dpapad@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-01-25 00:19:55]

Description was changed from

==========
MD Downloads: convert <paper-dropdown-menu> to <dialog is="cr-action-menu">

R=dpapad@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Downloads: convert <paper-dropdown-menu> to <dialog is="cr-action-menu">

Looks better and chops 66,664 bytes off vulcanized/crisper (pre-gzip).

R=dpapad@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-01-25 00:25:32]

Description was changed from

==========
MD Downloads: convert <paper-dropdown-menu> to <dialog is="cr-action-menu">

Looks better and chops 66,664 bytes off vulcanized/crisper (pre-gzip).

R=dpapad@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Downloads: convert <paper-dropdown-menu> to <dialog is="cr-action-menu">

Looks and acts better; chops 66,664 bytes off vulcanized/crisper (pre-gzip).

R=dpapad@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-01-25 00:25:40]

Patchset #1 (id:1) has been deleted

[dpapad, 2017-01-25 01:01:45]

LGTM.

You get the honor to update the checked in vulcanized code for one last time
before https://codereview.chromium.org/2569293002 (or you can wait until that
lands and reduce your diff).

https://codereview.chromium.org/2650303003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_downloads/toolbar.js (right):

https://codereview.chromium.org/2650303003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_downloads/toolbar.js:40:
this.$$('[is=cr-action-menu]').close();
Nit: Perhaps make the selector more specific (same below)?
'dialog[is=cr-action-menu]'

This is more aligned with current usage, see
https://cs.chromium.org/search/?q=%22dialog%5Bis%3Dcr-action-menu%5D%22&sq=pa....

[Dan Beam, 2017-01-25 01:46:27]

https://codereview.chromium.org/2650303003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_downloads/toolbar.js (right):

https://codereview.chromium.org/2650303003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_downloads/toolbar.js:40:
this.$$('[is=cr-action-menu]').close();
On 2017/01/25 01:01:45, dpapad wrote:
> Nit: Perhaps make the selector more specific (same below)?
> 'dialog[is=cr-action-menu]'
> 
> This is more aligned with current usage, see
>
https://cs.chromium.org/search/?q=%22dialog%5Bis%3Dcr-action-menu%5D%22&sq=pa....

Done.

[Dan Beam, 2017-01-25 01:46:33]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 01:47:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-01-25 02:36:47]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2017-01-25 02:36:53]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-01-25 02:36:54]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2650303003/#ps40001
(title: "browser test fixes")

[commit-bot: I haz the power, 2017-01-25 02:37:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 03:13:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485311813968830,
"parent_rev": "6c3436d4547dc143bdeee277f330d71cfa10af9f", "commit_rev":
"ad74cd3f5bb1ba01c0767a21edbb88057d4c20e9"}

[commit-bot: I haz the power, 2017-01-25 03:14:10]

Description was changed from

==========
MD Downloads: convert <paper-dropdown-menu> to <dialog is="cr-action-menu">

Looks and acts better; chops 66,664 bytes off vulcanized/crisper (pre-gzip).

R=dpapad@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Downloads: convert <paper-dropdown-menu> to <dialog is="cr-action-menu">

Looks and acts better; chops 66,664 bytes off vulcanized/crisper (pre-gzip).

R=dpapad@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2650303003
Cr-Commit-Position: refs/heads/master@{#445926}
Committed:
https://chromium.googlesource.com/chromium/src/+/ad74cd3f5bb1ba01c0767a21edbb...
==========

[commit-bot: I haz the power, 2017-01-25 03:14:12]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ad74cd3f5bb1ba01c0767a21edbb...