Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2569293002: WebUI: Vulcanize MD Downloads at compile time using GN. (Closed)

Created:
4 years ago by dpapad
Modified:
3 years, 11 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, asanka, chromium-reviews, dbeam+watch-downloads_chromium.org, michaelpg+watch-md-ui_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Vulcanize MD Downloads at compile time using GN. Deletes 240kb, 3400LOC of checked in generated code. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2569293002 Cr-Commit-Position: refs/heads/master@{#445934} Committed: https://chromium.googlesource.com/chromium/src/+/5d95e9acec76705c19a89060044582aba0818e4a

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Resolve conflicts. #

Patch Set 4 : Rebase #

Patch Set 5 : resolve conflits #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Patch Set 8 : Merge branch 'add_gn_vulcanize' into add_gn_vulcanize_downloads2 #

Patch Set 9 : Try windows fixes #

Patch Set 10 : Rebase #

Patch Set 11 : Nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3456 lines) Patch
M chrome/browser/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 2 3 4 5 2 chunks +3 lines, -5 lines 0 comments Download
A chrome/browser/resources/md_downloads/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 1 chunk +12 lines, -0 lines 0 comments Download
D chrome/browser/resources/md_downloads/crisper.js View 1 2 3 4 5 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/browser/resources/md_downloads/vulcanized.html View 1 2 3 4 5 1 chunk +0 lines, -3380 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 34 (30 generated)
dpapad
3 years, 11 months ago (2017-01-25 00:52:20 UTC) #25
Dan Beam
lgtm
3 years, 11 months ago (2017-01-25 02:24:02 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569293002/240001
3 years, 11 months ago (2017-01-25 02:57:40 UTC) #31
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 03:50:53 UTC) #34
Message was sent while issue was closed.
Committed patchset #11 (id:240001) as
https://chromium.googlesource.com/chromium/src/+/5d95e9acec76705c19a890600445...

Powered by Google App Engine
This is Rietveld 408576698