Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2650283002: Revert of Disable ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash (Closed)

Created:
3 years, 11 months ago by maniscalco
Modified:
3 years, 11 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash (patchset #2 id:20001 of https://codereview.chromium.org/2658463002/ ) Reason for revert: Reverting in favor of https://codereview.chromium.org/2656573004/ Original issue's description: > Disable ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash > > Test is flaky. Disable on Linux. > > TBR=lazyboy > BUG=684358 > > Review-Url: https://codereview.chromium.org/2658463002 > Cr-Commit-Position: refs/heads/master@{#445780} > Committed: https://chromium.googlesource.com/chromium/src/+/f611080eb86df037b4e687dc9d2821d68721d724 TBR=lazyboy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=684358 Review-Url: https://codereview.chromium.org/2650283002 Cr-Commit-Position: refs/heads/master@{#445785} Committed: https://chromium.googlesource.com/chromium/src/+/4dba42598478b220e70da6769c22b34cc1fef884

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/browser/extensions/extension_bindings_apitest.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
maniscalco
Created Revert of Disable ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash
3 years, 11 months ago (2017-01-24 19:53:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650283002/1
3 years, 11 months ago (2017-01-24 19:53:37 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 19:56:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4dba42598478b220e70da6769c22...

Powered by Google App Engine
This is Rietveld 408576698