Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2658463002: Disable ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash (Closed)

Created:
3 years, 11 months ago by maniscalco
Modified:
3 years, 11 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash Test is flaky. Disable on Linux. TBR=lazyboy BUG=684358 Review-Url: https://codereview.chromium.org/2658463002 Cr-Commit-Position: refs/heads/master@{#445780} Committed: https://chromium.googlesource.com/chromium/src/+/f611080eb86df037b4e687dc9d2821d68721d724

Patch Set 1 #

Patch Set 2 : Fix whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/extensions/extension_bindings_apitest.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
maniscalco
3 years, 11 months ago (2017-01-24 18:32:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658463002/20001
3 years, 11 months ago (2017-01-24 18:35:37 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f611080eb86df037b4e687dc9d2821d68721d724
3 years, 11 months ago (2017-01-24 19:39:58 UTC) #8
maniscalco
3 years, 11 months ago (2017-01-24 19:53:06 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2650283002/ by maniscalco@chromium.org.

The reason for reverting is: Reverting in favor of
https://codereview.chromium.org/2656573004/.

Powered by Google App Engine
This is Rietveld 408576698