Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2650233002: Revert of Add compiling of service_manager_unittests as temporary workaround. (Closed)

Created:
3 years, 11 months ago by kjellander_chromium
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add compiling of service_manager_unittests as temporary workaround. (patchset #1 id:1 of https://codereview.chromium.org/2655653002/ ) Reason for revert: Turns out another revert greened up this build. This is no longer needed. Original issue's description: > Add compiling of service_manager_unittests as temporary workaround. > > This will hopefully resolve the error WebRTC Android bots are seeing > when trying to run content_browsertests. > > BUG=684406 > TBR=aleloi@chromium.org > NOTRY=True > > Review-Url: https://codereview.chromium.org/2655653002 > Cr-Commit-Position: refs/heads/master@{#445733} > Committed: https://chromium.googlesource.com/chromium/src/+/c6f2c39f80a9238f90e3d425b844538e301302dc TBR=aleloi@chromium.org,rockot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=684406 Review-Url: https://codereview.chromium.org/2650233002 Cr-Commit-Position: refs/heads/master@{#445740} Committed: https://chromium.googlesource.com/chromium/src/+/3d4141d40471d274b0b66d2e938821137bcc0f9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M testing/buildbot/chromium.webrtc.fyi.json View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kjellander_chromium
Created Revert of Add compiling of service_manager_unittests as temporary workaround.
3 years, 11 months ago (2017-01-24 16:19:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650233002/1
3 years, 11 months ago (2017-01-24 16:20:12 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 16:21:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3d4141d40471d274b0b66d2e9388...

Powered by Google App Engine
This is Rietveld 408576698