Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2655653002:
Add compiling of service_manager_unittests as temporary workaround. (Closed)
|
Created:
3 years, 11 months ago by kjellander_chromium Modified:
3 years, 11 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd compiling of service_manager_unittests as temporary workaround.
This will hopefully resolve the error WebRTC Android bots are seeing
when trying to run content_browsertests.
BUG=684406
TBR=aleloi@chromium.org
NOTRY=True
Review-Url: https://codereview.chromium.org/2655653002
Cr-Commit-Position: refs/heads/master@{#445733}
Committed: https://chromium.googlesource.com/chromium/src/+/c6f2c39f80a9238f90e3d425b844538e301302dc
Patch Set 1 #
Messages
Total messages: 21 (10 generated)
The CQ bit was checked by kjellander@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM!
Description was changed from ========== Add compiling of service_manager_unittests as temporary workaround. This will hopefully resolve the error WebRTC Android bots are seeing when trying to run content_browsertests. BUG=684406 TBR=aleloi@chromium.org ========== to ========== Add compiling of service_manager_unittests as temporary workaround. This will hopefully resolve the error WebRTC Android bots are seeing when trying to run content_browsertests. BUG=684406 TBR=aleloi@chromium.org ==========
kjellander@chromium.org changed reviewers: + rockot@chromium.org
On 2017/01/24 13:43:17, aleloi1 wrote: > LGTM! Just FYI: this is entirely speculative, but it sounds like it might work. We should revert it once rockot@ has (hopefully) fixed the dependencies for service_manager.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
On 2017/01/24 14:07:20, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) Must be a flake. Resubmitting to CQ.
The CQ bit was checked by kjellander@chromium.org
The CQ bit was unchecked by kjellander@chromium.org
Description was changed from ========== Add compiling of service_manager_unittests as temporary workaround. This will hopefully resolve the error WebRTC Android bots are seeing when trying to run content_browsertests. BUG=684406 TBR=aleloi@chromium.org ========== to ========== Add compiling of service_manager_unittests as temporary workaround. This will hopefully resolve the error WebRTC Android bots are seeing when trying to run content_browsertests. BUG=684406 TBR=aleloi@chromium.org NOTRY=True ==========
On 2017/01/24 14:09:52, kjellander_chromium wrote: > On 2017/01/24 14:07:20, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) > > Must be a flake. Resubmitting to CQ. Submitting with NOTRY=True since I'm enough confident with the passing bots. This cannot possibly cause the breakages we're seeing here.
The CQ bit was checked by kjellander@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485272131486680, "parent_rev":
"527c6c30509994952b184ec09b96714144647c3d", "commit_rev":
"c6f2c39f80a9238f90e3d425b844538e301302dc"}
Message was sent while issue was closed.
Description was changed from ========== Add compiling of service_manager_unittests as temporary workaround. This will hopefully resolve the error WebRTC Android bots are seeing when trying to run content_browsertests. BUG=684406 TBR=aleloi@chromium.org NOTRY=True ========== to ========== Add compiling of service_manager_unittests as temporary workaround. This will hopefully resolve the error WebRTC Android bots are seeing when trying to run content_browsertests. BUG=684406 TBR=aleloi@chromium.org NOTRY=True Review-Url: https://codereview.chromium.org/2655653002 Cr-Commit-Position: refs/heads/master@{#445733} Committed: https://chromium.googlesource.com/chromium/src/+/c6f2c39f80a9238f90e3d425b844... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c6f2c39f80a9238f90e3d425b844...
Message was sent while issue was closed.
The CL which was causing this failure was reverted for other reasons several hours ago, so this change should be unnecessary. In any case, it does not seem like a reliable way to solve dependency issues. There are no guarantees about build order AFAICT. On Tue, Jan 24, 2017 at 7:40 AM, commit-bot@chromium.org via codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote: > Committed patchset #1 (id:1) as > https://chromium.googlesource.com/chromium/src/+/ > c6f2c39f80a9238f90e3d425b844538e301302dc > > https://codereview.chromium.org/2655653002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2650233002/ by kjellander@chromium.org. The reason for reverting is: Turns out another revert greened up this build. This is no longer needed.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
