Animations: Smooth interpolation for scale none

Animations: Smooth interpolation for scale none

When scale is animating or transitioning, and the
from value or to value (but not both) is none, the value
none is replaced by the equivalent identity value: 1

https://drafts.csswg.org/css-transforms-2/#individual-transforms


BUG=679873
Review-Url: https://codereview.chromium.org/2650163002
Cr-Commit-Position: refs/heads/master@{#447133}
Committed: https://chromium.googlesource.com/chromium/src/+/ef1582831d30d9f9e4db73ad0be2a812874f8568

[Eric Willigers, 2017-01-30 04:43:27]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 04:43:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2017-01-30 04:45:02]

Description was changed from

==========
[WIP] Animations: Smooth interpolation for individual transforms' none

When translate or scale are animating or transitioning, and the
from value or to value (but not both) is none, the value none is
replaced by the equivalent identity value
(0px for translate, 1 for scale).

https://drafts.csswg.org/css-transforms-2/#individual-transforms


(rotate will need to be updated, see
https://codereview.chromium.org/2625313002/ )


BUG=679873
==========

to

==========
Animations: Smooth interpolation for scale none

When scale is animating or transitioning, and the
from value or to value (but not both) is none, the value
none is replaced by the equivalent identity value: 1

https://drafts.csswg.org/css-transforms-2/#individual-transforms


BUG=679873
==========

[Eric Willigers, 2017-01-30 04:45:02]

ericwilligers@chromium.org changed reviewers:
+ alancutter@chromium.org

[commit-bot: I haz the power, 2017-01-30 05:01:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 05:01:44]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Eric Willigers, 2017-01-30 05:45:35]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 05:45:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 07:21:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 07:21:43]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2017-01-30 21:32:06]

lgtm after comments addressed.

https://codereview.chromium.org/2650163002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp
(right):

https://codereview.chromium.org/2650163002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp:62:
return std::move(list);
I don't think std::move is required here.

https://codereview.chromium.org/2650163002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp:195:
std::move(end.interpolableValue);
You can directly modify start/end.interpolableValue, no need for these
temporaries.

https://codereview.chromium.org/2650163002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp:236: }
Just set it to createIdentityInterpolableValue() and let the following code do
the additive logic.

[Eric Willigers, 2017-01-30 21:56:32]

https://codereview.chromium.org/2650163002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp
(right):

https://codereview.chromium.org/2650163002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp:62:
return std::move(list);
On 2017/01/30 21:32:06, alancutter wrote:
> I don't think std::move is required here.

I didn't have std::move in Patch Set 2. This failed to compile on some platforms
(e.g. android, chromeos).

I added std::move in Patch Set 3, and made no other changes. This successfully
compiled and passed tests on all platforms.

https://codereview.chromium.org/2650163002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp:195:
std::move(end.interpolableValue);
On 2017/01/30 21:32:06, alancutter wrote:
> You can directly modify start/end.interpolableValue, no need for these
> temporaries.

Done.

https://codereview.chromium.org/2650163002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp:236: }
On 2017/01/30 21:32:06, alancutter wrote:
> Just set it to createIdentityInterpolableValue() and let the following code do
> the additive logic.

Done.

[Eric Willigers, 2017-01-30 21:57:08]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 21:57:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 23:51:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 23:51:53]

Dry run: This issue passed the CQ dry run.

[sashab, 2017-01-31 00:29:55]

sashab@chromium.org changed reviewers:
+ sashab@chromium.org

[sashab, 2017-01-31 00:29:56]

style/ LGTM

[Eric Willigers, 2017-01-31 00:30:48]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2017-01-31 00:30:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2650163002/#ps60001
(title: "reviewFeedback")

[commit-bot: I haz the power, 2017-01-31 00:31:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 00:36:48]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485822648112520,
"parent_rev": "d45c2e686cfea25c8e480cbb5604ef1bc5dfae0f", "commit_rev":
"ef1582831d30d9f9e4db73ad0be2a812874f8568"}

[commit-bot: I haz the power, 2017-01-31 00:37:23]

Description was changed from

==========
Animations: Smooth interpolation for scale none

When scale is animating or transitioning, and the
from value or to value (but not both) is none, the value
none is replaced by the equivalent identity value: 1

https://drafts.csswg.org/css-transforms-2/#individual-transforms


BUG=679873
==========

to

==========
Animations: Smooth interpolation for scale none

When scale is animating or transitioning, and the
from value or to value (but not both) is none, the value
none is replaced by the equivalent identity value: 1

https://drafts.csswg.org/css-transforms-2/#individual-transforms


BUG=679873

Review-Url: https://codereview.chromium.org/2650163002
Cr-Commit-Position: refs/heads/master@{#447133}
Committed:
https://chromium.googlesource.com/chromium/src/+/ef1582831d30d9f9e4db73ad0be2...
==========

[commit-bot: I haz the power, 2017-01-31 00:37:24]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ef1582831d30d9f9e4db73ad0be2...