Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp

Issue 2650163002: Animations: Smooth interpolation for scale none (Closed)
Patch Set: reviewFeedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
diff --git a/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp b/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
index 868d4faf2ff2b543f0e7f26ba67b05380af4d2a1..3c853cc83d3507c4f8134cbe61084318e8a9d147 100644
--- a/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
+++ b/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
@@ -303,7 +303,8 @@ static PassRefPtr<AnimatableValue> createFromTransformProperties(
double zoom,
PassRefPtr<TransformOperation> initialTransform) {
TransformOperations operation;
- operation.operations().push_back(transform ? transform : initialTransform);
+ if (transform || initialTransform)
+ operation.operations().push_back(transform ? transform : initialTransform);
return AnimatableTransform::create(operation, transform ? zoom : 1);
}
@@ -624,11 +625,8 @@ PassRefPtr<AnimatableValue> CSSAnimatableValueFactory::create(
style.rotate(), style.effectiveZoom(), initialRotate);
}
case CSSPropertyScale: {
- DEFINE_STATIC_REF(ScaleTransformOperation, initialScale,
- ScaleTransformOperation::create(
- 1, 1, 1, TransformOperation::Scale3D));
return createFromTransformProperties(style.scale(), style.effectiveZoom(),
- initialScale);
+ nullptr);
}
case CSSPropertyOffsetAnchor:
return createFromLengthPoint(style.offsetAnchor(), style);

Powered by Google App Engine
This is Rietveld 408576698