Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2650133003: [Android] Enable spellcheck on non low-end devices by default. (Closed)

Created:
3 years, 11 months ago by timvolodine
Modified:
3 years, 11 months ago
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Android] Enable spellcheck on non low-end devices by default. Merge to M57 (2987) Currently spellcheck is being rolled out to all builds of M56 via finch. This patch ensures spellcheck functionality continues to be on for M57 and up on non low-end devices (i.e. having > 512MB RAM). Also ensure that spellcheck can be disabled/enabled on non low-end devices via chrome://flags. BUG=629609, 683922 TBR=tobiasjs@chromium.org,groby@chromium.org,isherman@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2636843004 Cr-Commit-Position: refs/heads/master@{#445454} (cherry picked from commit be9a2649f4d349f42acc658d90cc78ef7b170d87) Review-Url: https://codereview.chromium.org/2650133003 Cr-Commit-Position: refs/branch-heads/2987@{#70} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/2b628695210d74bb18ad5b818681413afbdfde26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/spellcheck/common/spellcheck_features.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650133003/1
3 years, 11 months ago (2017-01-24 19:48:06 UTC) #2
timvolodine
FYI this is a merge
3 years, 11 months ago (2017-01-24 19:49:27 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 19:50:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2b628695210d74bb18ad5b818681...

Powered by Google App Engine
This is Rietveld 408576698