|
|
Chromium Code Reviews|
Created:
3 years, 11 months ago by timvolodine Modified:
3 years, 11 months ago CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org, timvolodine Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Android] Enable spellcheck on non low-end devices by default.
Currently spellcheck is being rolled out to all builds of M56 via
finch. This patch ensures spellcheck functionality continues to be
on for M57 and up on non low-end devices (i.e. having > 512MB RAM).
Also ensure that spellcheck can be disabled/enabled on non low-end
devices via chrome://flags.
BUG=629609, 683922
Review-Url: https://codereview.chromium.org/2636843004
Cr-Commit-Position: refs/heads/master@{#445454}
Committed: https://chromium.googlesource.com/chromium/src/+/be9a2649f4d349f42acc658d90cc78ef7b170d87
Patch Set 1 #Patch Set 2 : git cl format #Patch Set 3 : update about_flags #Patch Set 4 : keep the logic #Patch Set 5 : update histograms.xml #
Messages
Total messages: 35 (23 generated)
The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
timvolodine@chromium.org changed reviewers: + groby@chromium.org, tobiasjs@chromium.org
will need to land this preferably before branch point this week :)
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/01/17 13:51:59, Tobias Sargeant wrote: > lgtm lgtm
Description was changed from ========== [Android] Enable spellcheck on non low-end devices by default. Currently spellcheck is being rolled out to all builds of M56 via finch. This patch ensures spellcheck functionality continues to be on for M57 and up on non low-end devices (i.e. having > 512MB RAM). Also ensure that spellcheck can be enabled via chrome://flags on any device. BUG=629609 ========== to ========== [Android] Enable spellcheck on non low-end devices by default. Currently spellcheck is being rolled out to all builds of M56 via finch. This patch ensures spellcheck functionality continues to be on for M57 and up on non low-end devices (i.e. having > 512MB RAM). Also ensure that spellcheck can be disabled/enabled on non low-end devices via chrome://flags. BUG=629609 ==========
thanks for the quick turnaround! [ also updated about_flags to allow disabling spellcheck if a user doesn't like it for some reason -- will never happen of course ;) ]
The CQ bit was checked by timvolodine@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org, tobiasjs@chromium.org Link to the patchset: https://codereview.chromium.org/2636843004/#ps60001 (title: "keep the logic")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by timvolodine@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by timvolodine@chromium.org
The CQ bit was unchecked by timvolodine@chromium.org
The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
timvolodine@chromium.org changed reviewers: + isherman@chromium.org
+isherman@: for histograms.xml
Description was changed from ========== [Android] Enable spellcheck on non low-end devices by default. Currently spellcheck is being rolled out to all builds of M56 via finch. This patch ensures spellcheck functionality continues to be on for M57 and up on non low-end devices (i.e. having > 512MB RAM). Also ensure that spellcheck can be disabled/enabled on non low-end devices via chrome://flags. BUG=629609 ========== to ========== [Android] Enable spellcheck on non low-end devices by default. Currently spellcheck is being rolled out to all builds of M56 via finch. This patch ensures spellcheck functionality continues to be on for M57 and up on non low-end devices (i.e. having > 512MB RAM). Also ensure that spellcheck can be disabled/enabled on non low-end devices via chrome://flags. BUG=629609,683922 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
histograms.xml lgtm
The CQ bit was checked by isherman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org, tobiasjs@chromium.org Link to the patchset: https://codereview.chromium.org/2636843004/#ps80001 (title: "update histograms.xml")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485201791719470,
"parent_rev": "f5600ef4dc75558dd888842e742df522550fefc5", "commit_rev":
"be9a2649f4d349f42acc658d90cc78ef7b170d87"}
Message was sent while issue was closed.
Description was changed from ========== [Android] Enable spellcheck on non low-end devices by default. Currently spellcheck is being rolled out to all builds of M56 via finch. This patch ensures spellcheck functionality continues to be on for M57 and up on non low-end devices (i.e. having > 512MB RAM). Also ensure that spellcheck can be disabled/enabled on non low-end devices via chrome://flags. BUG=629609,683922 ========== to ========== [Android] Enable spellcheck on non low-end devices by default. Currently spellcheck is being rolled out to all builds of M56 via finch. This patch ensures spellcheck functionality continues to be on for M57 and up on non low-end devices (i.e. having > 512MB RAM). Also ensure that spellcheck can be disabled/enabled on non low-end devices via chrome://flags. BUG=629609,683922 Review-Url: https://codereview.chromium.org/2636843004 Cr-Commit-Position: refs/heads/master@{#445454} Committed: https://chromium.googlesource.com/chromium/src/+/be9a2649f4d349f42acc658d90cc... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/be9a2649f4d349f42acc658d90cc... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
