Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 2636843004: [Android] Enable spellcheck on non low-end devices by default. (Closed)

Created:
3 years, 11 months ago by timvolodine
Modified:
3 years, 11 months ago
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Enable spellcheck on non low-end devices by default. Currently spellcheck is being rolled out to all builds of M56 via finch. This patch ensures spellcheck functionality continues to be on for M57 and up on non low-end devices (i.e. having > 512MB RAM). Also ensure that spellcheck can be disabled/enabled on non low-end devices via chrome://flags. BUG=629609, 683922 Review-Url: https://codereview.chromium.org/2636843004 Cr-Commit-Position: refs/heads/master@{#445454} Committed: https://chromium.googlesource.com/chromium/src/+/be9a2649f4d349f42acc658d90cc78ef7b170d87

Patch Set 1 #

Patch Set 2 : git cl format #

Patch Set 3 : update about_flags #

Patch Set 4 : keep the logic #

Patch Set 5 : update histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/about_flags.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/spellcheck/common/spellcheck_features.cc View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 35 (23 generated)
timvolodine
will need to land this preferably before branch point this week :)
3 years, 11 months ago (2017-01-17 13:46:23 UTC) #4
Tobias Sargeant
lgtm
3 years, 11 months ago (2017-01-17 13:51:59 UTC) #5
groby-ooo-7-16
On 2017/01/17 13:51:59, Tobias Sargeant wrote: > lgtm lgtm
3 years, 11 months ago (2017-01-17 14:44:06 UTC) #8
timvolodine
thanks for the quick turnaround! [ also updated about_flags to allow disabling spellcheck if a ...
3 years, 11 months ago (2017-01-19 20:30:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636843004/60001
3 years, 11 months ago (2017-01-19 20:30:46 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/103444)
3 years, 11 months ago (2017-01-19 21:57:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636843004/60001
3 years, 11 months ago (2017-01-19 22:10:04 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/216501)
3 years, 11 months ago (2017-01-19 23:44:19 UTC) #19
timvolodine
+isherman@: for histograms.xml
3 years, 11 months ago (2017-01-23 17:53:09 UTC) #25
Ilya Sherman
histograms.xml lgtm
3 years, 11 months ago (2017-01-23 20:02:57 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636843004/80001
3 years, 11 months ago (2017-01-23 20:04:28 UTC) #32
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 20:11:03 UTC) #35
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/be9a2649f4d349f42acc658d90cc...

Powered by Google App Engine
This is Rietveld 408576698