Issue 265013003: Revert of Remove setLocalMatrix calls from picture shader GM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 265013003: Revert of Remove setLocalMatrix calls from picture shader GM. (Closed)

Created:
6 years, 7 months ago by mtklein

Modified:
6 years, 7 months ago

Reviewers:
fmalita_google_do_not_use, mtklein_C, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Revert of Remove setLocalMatrix calls from picture shader GM. (https://codereview.chromium.org/260863007/) Reason for revert: changed GM unexpectedly. will sort out and try again Original issue's description: > Remove setLocalMatrix calls from picture shader GM. > > This makes all --skr tests pass for me. Enabling it by default in DM. > > BUG=skia:2378 > > Committed: http://code.google.com/p/skia/source/detail?r=14549 TBR=reed@google.com,fmalita@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14550

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -34 lines)			Patch
M	dm/DMRecordTask.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/pictureshader.cpp	View	5 chunks	+26 lines, -19 lines	0 comments	Download
M	include/core/SkShader.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/core/SkPictureShader.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/core/SkPictureShader.cpp	View	3 chunks	+3 lines, -7 lines	0 comments	Download
M	src/core/SkShader.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of Remove setLocalMatrix calls from picture shader GM.

6 years, 7 months ago (2014-05-02 20:50:55 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/265013003/1

6 years, 7 months ago (2014-05-02 20:51:05 UTC) #2

Message was sent while issue was closed.

Change committed as 14550