Updated descendant condition for header/footer AX role mapping.

Updated descendant condition for header/footer AX role mapping.

This patch doesn't assign header and footer roles for
descendants of main or other sectioning content or
sectioning root element.

BUG=591328
Review-Url: https://codereview.chromium.org/2649953004
Cr-Commit-Position: refs/heads/master@{#447974}
Committed: https://chromium.googlesource.com/chromium/src/+/8a0d208a1fff647a2e9861f82462f60c4368efa5

[je_julie, 2017-01-25 07:57:30]

je_julie.kim@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[je_julie, 2017-01-25 07:57:30]

Hi Dominic,
It's been a long time.
I uploaded the patch to fix header and footer role mapping with updated spec.
https://www.w3.org/TR/html-aam-1.0/
Spec says that header and footer roles are available only with descendant of
body but not of main or other sectioning content or sectioning root element.
PTAL.

[dmazzoni, 2017-02-02 16:40:06]

lgtm

Thank you! Your contributions are always appreciated!!!

https://codereview.chromium.org/2649953004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/2649953004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:415: static
HashSet<QualifiedName>& getLandmarkRoleBlocked() {
Just for consistency, either call the function getLandmarkRoleNotAllowed,
or change the HashSet to landmarkRoleBlocked.

I think I prefer: getLandmarkRolesNotAllowed() and landmarkRolesNotAllowed.

[je_julie, 2017-02-03 08:32:45]

Thanks a lot!
I'll try to land the updated patchset which includes modification as following
your suggestion.

https://codereview.chromium.org/2649953004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/2649953004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:415: static
HashSet<QualifiedName>& getLandmarkRoleBlocked() {
On 2017/02/02 16:40:06, dmazzoni wrote:
> Just for consistency, either call the function getLandmarkRoleNotAllowed,
> or change the HashSet to landmarkRoleBlocked.
> 
> I think I prefer: getLandmarkRolesNotAllowed() and landmarkRolesNotAllowed.

I updated with getLandmarkRolesNotAllowed() and landmarkRolesNotAllowed with new
patchset.

[je_julie, 2017-02-03 08:51:30]

The CQ bit was checked by je_julie.kim@chromium.org

[je_julie, 2017-02-03 08:51:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2649953004/#ps60001
(title: "addressed review comment")

[commit-bot: I haz the power, 2017-02-03 08:51:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 08:51:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 08:51:46]

The author je_julie.kim@chromium.org has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.

[je_julie, 2017-02-03 09:28:15]

The CQ bit was checked by je_julie.kim@chromium.org

[commit-bot: I haz the power, 2017-02-03 09:28:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 11:03:09]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486114095553630,
"parent_rev": "3500cacdae6e8bcdb6371576ca7d08d7465eb9e7", "commit_rev":
"8a0d208a1fff647a2e9861f82462f60c4368efa5"}

[commit-bot: I haz the power, 2017-02-03 11:03:39]

Description was changed from

==========
Updated descendant condition for header/footer AX role mapping.

This patch doesn't assign header and footer roles for
descendants of main or other sectioning content or
sectioning root element.

BUG=591328
==========

to

==========
Updated descendant condition for header/footer AX role mapping.

This patch doesn't assign header and footer roles for
descendants of main or other sectioning content or
sectioning root element.

BUG=591328

Review-Url: https://codereview.chromium.org/2649953004
Cr-Commit-Position: refs/heads/master@{#447974}
Committed:
https://chromium.googlesource.com/chromium/src/+/8a0d208a1fff647a2e9861f82462...
==========

[commit-bot: I haz the power, 2017-02-03 11:03:40]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8a0d208a1fff647a2e9861f82462...