third_party/WebKit/Source/modules/accessibility/AXNodeObject.h - Issue 2649953004: Updated descendant condition for header/footer AX role mapping.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

Issue 2649953004: Updated descendant condition for header/footer AX role mapping. (Closed)

Patch Set: addressed review comment Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

diff --git a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

index 2a086287e797462fd064d91e7c3e2760701ede82..0a2b8dd0c77dd6310e42ea9a3a60e0c31f1f41e5 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

+++ b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

@@ -237,7 +237,7 @@ class MODULES_EXPORT AXNodeObject : public AXObject {

NameSources*,

bool* foundTextAlternative) const;

float stepValueForRange() const;

- bool isDescendantOfElementType(const HTMLQualifiedName& tagName) const;

+ bool isDescendantOfElementType(HashSet<QualifiedName>& tagNames) const;

String placeholderFromNativeAttribute() const;

};