Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 2649953003: Don't assume every cell in a row has a column (Closed)

Created:
3 years, 11 months ago by rhogan
Modified:
3 years, 11 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't assume every cell in a row has a column BUG=683594 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2649953003 Cr-Commit-Position: refs/heads/master@{#445474} Committed: https://chromium.googlesource.com/chromium/src/+/f0f5a49bb64045baf41a50c470540a0e86ddcf67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/fast/table/backgr_image-crash.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/table/backgr_image-crash-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
rhogan
3 years, 11 months ago (2017-01-23 18:50:17 UTC) #4
Xianzhu
lgtm
3 years, 11 months ago (2017-01-23 18:51:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649953003/1
3 years, 11 months ago (2017-01-23 20:36:28 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 20:42:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f0f5a49bb64045baf41a50c47054...

Powered by Google App Engine
This is Rietveld 408576698