Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp

Issue 2649953003: Don't assume every cell in a row has a column (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/table/backgr_image-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp
diff --git a/third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp b/third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp
index e4e53fff0e8652e4db32a32d6eaf8ad22b5ca79d..85cfd59807b1c23ebcbcd70b8d39bdd30037b0da 100644
--- a/third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp
+++ b/third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp
@@ -332,10 +332,11 @@ static void expandToTableColumnGroup(const LayoutTableCell& cell,
: &LayoutTableCell::nextCell;
for (const auto* sibling = (cell.*siblingCell)(); sibling;
sibling = (sibling->*siblingCell)()) {
- if (cell.table()
+ LayoutTableCol* innermostCol =
+ cell.table()
->colElementAtAbsoluteColumn(sibling->absoluteColumnIndex())
- .innermostColOrColGroup()
- ->enclosingColumnGroup() != columnGroup)
+ .innermostColOrColGroup();
+ if (!innermostCol || innermostCol->enclosingColumnGroup() != columnGroup)
break;
value += sibling->size().width();
}
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/table/backgr_image-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698