Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2649923007: Revert of Show service worker navigation preload requests in DevTools Network tab (Closed)

Created:
3 years, 11 months ago by horo
Modified:
3 years, 11 months ago
Reviewers:
falken, pfeldman
CC:
chromium-reviews, michaeln, mlamouri+watch-content_chromium.org, tzik, jsbell+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, blink-reviews-api_chromium.org, haraken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org, blink-reviews, darin-cc_chromium.org, kinuko+watch, shimazu+serviceworker_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Show service worker navigation preload requests in DevTools Network tab (patchset #9 id:460001 of https://codereview.chromium.org/2620463002/ ) Reason for revert: Caused layout test failures. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=http%2Ftests%2Finspector%2Fservice-workers%2Flazy-addeventlisteners.html Original issue's description: > Show service worker navigation preload requests in DevTools Network tab. > > Demo: https://youtu.be/I-Qe_Y-xYxE > > Navigation Preload requests are initiated from the browser process. > This is different from the normal network requests which are initiated from the > renderer process. > > When the DevTools show the normal requests in the Network tab, DevTool's > Network events (requestWillBeSent, responseReceived, loadingFinished etc) are > dispatched via InspectorInstrumentation and InspectorNetworkAgent. > > This CL introduces new DevTool's Network events (navigationPreloadSent, > navigationPreloadResponseReceived, navigationPreloadFailed, > navigationPreloadFinished) which are dispatched via InspectorInstrumentation and > InspectorNetworkAgent from ServiceWorkerContextClient. > > In the normal requests case, we record the request sending timestamp when the > renderer process will send the request in InspectorNetworkAgent:: > willSendRequestInternal(). But in the navigation preload case, we record the > timestamp in the browser process, and send it to the service worker's renderer > process using FetchEventPreloadHandle. > > > BUG=649558 > > Review-Url: https://codereview.chromium.org/2620463002 > Cr-Commit-Position: refs/heads/master@{#445630} > Committed: https://chromium.googlesource.com/chromium/src/+/4c6b3b0f11b62e069d9d84ba99dbe94a45a5c622 TBR=falken@chromium.org,pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=649558 Review-Url: https://codereview.chromium.org/2649923007 Cr-Commit-Position: refs/heads/master@{#445684} Committed: https://chromium.googlesource.com/chromium/src/+/f0d113c2a563169ac97086771a3ea3a24bebd73d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -391 lines) Patch
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +1 line, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_fetch_dispatcher.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 5 chunks +9 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/resources/navigation-preload-scope.php View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/resources/navigation-preload-worker.php View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-navigation-preload.html View 1 chunk +0 lines, -130 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-navigation-preload-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h View 2 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 9 chunks +21 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.h View 3 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 3 chunks +4 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 4 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadStartupData.h View 3 chunks +3 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadStartupData.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js View 2 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioWorkletThreadTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 6 chunks +0 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
horo
Created Revert of Show service worker navigation preload requests in DevTools Network tab
3 years, 11 months ago (2017-01-24 08:47:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649923007/1
3 years, 11 months ago (2017-01-24 08:47:24 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 08:49:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f0d113c2a563169ac97086771a3e...

Powered by Google App Engine
This is Rietveld 408576698