Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js

Issue 2649923007: Revert of Show service worker navigation preload requests in DevTools Network tab (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js
index f65ec3a617093e58b8c3cc54b0abebd066f5ea1c..d5845ad8eb2bb4fa04e23c6adfde410c8b483efd 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js
@@ -130,15 +130,8 @@
* @return {number}
*/
_capabilitiesForType(type) {
- if (type === 'worker') {
- var capabilities = SDK.Target.Capability.JS | SDK.Target.Capability.Log;
- var parentTargetInfo = this.targetInfo(this.target());
- var mainIsServiceWorker =
- !this.target().parentTarget() && this.target().hasTargetCapability() && !this.target().hasJSCapability();
- if ((parentTargetInfo && parentTargetInfo.type === 'service_worker') || mainIsServiceWorker)
- capabilities |= SDK.Target.Capability.Network;
- return capabilities;
- }
+ if (type === 'worker')
+ return SDK.Target.Capability.JS | SDK.Target.Capability.Log;
if (type === 'service_worker')
return SDK.Target.Capability.Log | SDK.Target.Capability.Network | SDK.Target.Capability.Target;
if (type === 'iframe') {
@@ -170,7 +163,7 @@
// Only pause new worker if debugging SW - we are going through the pause on start checkbox.
var mainIsServiceWorker =
- !this.target().parentTarget() && this.target().hasTargetCapability() && !this.target().hasJSCapability();
+ !this.target().parentTarget() && this.target().hasTargetCapability() && !this.target().hasBrowserCapability();
if (mainIsServiceWorker && waitingForDebugger)
target.debuggerAgent().pause();
target.runtimeAgent().runIfWaitingForDebugger();

Powered by Google App Engine
This is Rietveld 408576698