Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: pkg/compiler/lib/src/parser/node_listener.dart

Issue 2649923002: Update listener error handling. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/parser/member_listener.dart ('k') | pkg/dart_parser/lib/src/error_kind.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/parser/node_listener.dart
diff --git a/pkg/compiler/lib/src/parser/node_listener.dart b/pkg/compiler/lib/src/parser/node_listener.dart
index 1e2e6c6a186d72504f06c05fac5ee19c9ee36d37..ff5d5a3db588119ab489d475f21185e4db57b34b 100644
--- a/pkg/compiler/lib/src/parser/node_listener.dart
+++ b/pkg/compiler/lib/src/parser/node_listener.dart
@@ -288,7 +288,8 @@ class NodeListener extends ElementListener {
reportErrorToken(token);
} else {
reportFatalError(
- token, "Expected a function body, but got '${token.value}'.");
+ reporter.spanFromToken(token),
+ "Expected a function body, but got '${token.value}'.");
}
return skipToEof(token);
}
@@ -300,7 +301,8 @@ class NodeListener extends ElementListener {
return skipToEof(token);
} else {
reportFatalError(
- token, "Expected a class body, but got '${token.value}'.");
+ reporter.spanFromToken(token),
+ "Expected a class body, but got '${token.value}'.");
return skipToEof(token);
}
}
@@ -343,7 +345,8 @@ class NodeListener extends ElementListener {
if (argumentSend == null) {
// TODO(ahe): The parser should diagnose this problem, not
// this listener.
- reportFatalError(argument, 'Expected an identifier.');
+ reportFatalError(reporter.spanFromSpannable(argument),
+ "Expected an identifier.");
}
if (argumentSend.receiver != null) internalError(node: argument);
if (argument is SendSet) internalError(node: argument);
@@ -408,7 +411,7 @@ class NodeListener extends ElementListener {
void reportNotAssignable(Node node) {
// TODO(ahe): The parser should diagnose this problem, not this
// listener.
- reportFatalError(node, 'Not assignable.');
+ reportFatalError(reporter.spanFromSpannable(node), "Not assignable.");
}
@override
« no previous file with comments | « pkg/compiler/lib/src/parser/member_listener.dart ('k') | pkg/dart_parser/lib/src/error_kind.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698