Issue 2649833002: Retrieve NTP thumbnail URLs from the right frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2649833002: Retrieve NTP thumbnail URLs from the right frame (Closed)

Created:
3 years, 11 months ago by Sam McNally

Modified:
3 years, 11 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

Retrieve NTP thumbnail URLs from the right frame The SearchBox instance, which stores state used in NTP, only lives on the main frame. In one instance where we looked this up we mistakenly looked in the child frame. BUG=681749 Review-Url: https://codereview.chromium.org/2646133003 Cr-Commit-Position: refs/heads/master@{#445072} (cherry picked from commit 73a0a9657be8e61ebb32464455454cd631ee2a80) Review-Url: https://codereview.chromium.org/2649833002 . Cr-Commit-Position: refs/branch-heads/2987@{#17} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/bda82aa1bd8d279e005a2c158786318e0e3a0b18

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -5 lines)			Patch
	M	chrome/renderer/chrome_content_renderer_client.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/renderer/chrome_content_renderer_client_browsertest.cc	View		3 chunks	+37 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

Sam McNally

3 years, 11 months ago (2017-01-23 05:48:25 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bda82aa1bd8d279e005a2c158786318e0e3a0b18.