Retrieve NTP thumbnail URLs from the right frame

Retrieve NTP thumbnail URLs from the right frame

The SearchBox instance, which stores state used in NTP, only lives on the main
frame. In one instance where we looked this up we mistakenly looked in the child
frame.

BUG=681749
Review-Url: https://codereview.chromium.org/2646133003
Cr-Commit-Position: refs/heads/master@{#445072}
Committed: https://chromium.googlesource.com/chromium/src/+/73a0a9657be8e61ebb32464455454cd631ee2a80

[Marc Treib, 2017-01-20 15:03:53]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 15:04:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2017-01-20 15:04:09]

Description was changed from

==========
# Enter a description of the change.
–Retrieve NTP thumbnails URLs from the right frame

The SearchBox instance, which stores state used in NTP, only lives on the main
frame. In one instance where we looked this up we mistakenly looked in the child
frame.

BUG=681749
==========

to

==========
–Retrieve NTP thumbnails URLs from the right frame

The SearchBox instance, which stores state used in NTP, only lives on the main
frame. In one instance where we looked this up we mistakenly looked in the child
frame.

BUG=681749
==========

[Marc Treib, 2017-01-20 15:10:18]

treib@chromium.org changed reviewers:
+ jochen@chromium.org, tibell@chromium.org

[Marc Treib, 2017-01-20 15:10:19]

This is tibell's https://codereview.chromium.org/2639823002/ plus a unit test
(thanks jochen for the help!)
PTAL!

[Marc Treib, 2017-01-20 15:13:48]

Description was changed from

==========
–Retrieve NTP thumbnails URLs from the right frame

The SearchBox instance, which stores state used in NTP, only lives on the main
frame. In one instance where we looked this up we mistakenly looked in the child
frame.

BUG=681749
==========

to

==========
Retrieve NTP thumbnails URLs from the right frame

The SearchBox instance, which stores state used in NTP, only lives on the main
frame. In one instance where we looked this up we mistakenly looked in the child
frame.

BUG=681749
==========

[Marc Treib, 2017-01-20 15:13:58]

Description was changed from

==========
Retrieve NTP thumbnails URLs from the right frame

The SearchBox instance, which stores state used in NTP, only lives on the main
frame. In one instance where we looked this up we mistakenly looked in the child
frame.

BUG=681749
==========

to

==========
Retrieve NTP thumbnail URLs from the right frame

The SearchBox instance, which stores state used in NTP, only lives on the main
frame. In one instance where we looked this up we mistakenly looked in the child
frame.

BUG=681749
==========

[jochen (gone - plz use gerrit), 2017-01-20 15:21:42]

lgtm

[commit-bot: I haz the power, 2017-01-20 15:41:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 15:41:11]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-01-20 16:27:13]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2017-01-20 16:27:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 16:31:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484929633002870, "parent_rev":
"69e7e3b844f1cedf53701f07bf0d3219fc2d3176", "commit_rev":
"73a0a9657be8e61ebb32464455454cd631ee2a80"}

[commit-bot: I haz the power, 2017-01-20 16:31:37]

Description was changed from

==========
Retrieve NTP thumbnail URLs from the right frame

The SearchBox instance, which stores state used in NTP, only lives on the main
frame. In one instance where we looked this up we mistakenly looked in the child
frame.

BUG=681749
==========

to

==========
Retrieve NTP thumbnail URLs from the right frame

The SearchBox instance, which stores state used in NTP, only lives on the main
frame. In one instance where we looked this up we mistakenly looked in the child
frame.

BUG=681749

Review-Url: https://codereview.chromium.org/2646133003
Cr-Commit-Position: refs/heads/master@{#445072}
Committed:
https://chromium.googlesource.com/chromium/src/+/73a0a9657be8e61ebb3246445545...
==========

[commit-bot: I haz the power, 2017-01-20 16:31:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/73a0a9657be8e61ebb3246445545...

[tibell, 2017-01-22 22:40:45]

lgtm