Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2672)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java

Issue 2649773007: Destroy incognito profile from close all incognito notification. (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java b/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java
index fe760183e57022164a114d19219364730e97e3fb..6135898e7966d2f0daf7e19db0ba72cd4b13c136 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java
@@ -23,12 +23,15 @@ import org.chromium.base.ApplicationStatus;
import org.chromium.base.ContextUtils;
import org.chromium.base.ThreadUtils;
import org.chromium.base.VisibleForTesting;
+import org.chromium.base.library_loader.LibraryProcessType;
import org.chromium.chrome.browser.ChromeTabbedActivity;
import org.chromium.chrome.browser.TabState;
import org.chromium.chrome.browser.document.ChromeLauncherActivity;
import org.chromium.chrome.browser.document.DocumentUtils;
+import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.tabmodel.TabWindowManager;
import org.chromium.chrome.browser.tabmodel.TabbedModeTabPersistencePolicy;
+import org.chromium.content.browser.BrowserStartupController;
import java.io.File;
import java.lang.ref.WeakReference;
@@ -72,10 +75,18 @@ public class IncognitoNotificationService extends IntentService {
@Override
public void run() {
int incognitoCount = TabWindowManager.getInstance().getIncognitoTabCount();
- assert incognitoCount == 0;
-
- if (incognitoCount == 0) {
- IncognitoNotificationManager.dismissIncognitoNotification();
+ if (incognitoCount != 0) {
+ assert false : "Not all incognito tabs closed as expected";
+ return;
+ }
+ IncognitoNotificationManager.dismissIncognitoNotification();
+
+ if (BrowserStartupController.get(LibraryProcessType.PROCESS_BROWSER)
+ .isStartupSuccessfullyCompleted()) {
+ if (Profile.getLastUsedProfile().hasOffTheRecordProfile()) {
+ Profile.getLastUsedProfile().getOffTheRecordProfile()
+ .destroyWhenAppropriate();
+ }
}
}
});

Powered by Google App Engine
This is Rietveld 408576698